Skip to content

disable music-replacer#10743

Merged
pajlada merged 1 commit into
runelite:masterfrom
Felanbird:patch-2
Feb 25, 2026
Merged

disable music-replacer#10743
pajlada merged 1 commit into
runelite:masterfrom
Felanbird:patch-2

Conversation

@Felanbird
Copy link
Copy Markdown
Contributor

@Felanbird Felanbird commented Feb 25, 2026

this is very broken

felanbird-webm.webm

@runelite-github-app
Copy link
Copy Markdown

Includes changes by non-author

music-replacer: 2fb6f77c6163da225b332bd374732bbe2e56ba91..2fb6f77c6163da225b332bd374732bbe2e56ba91

@runelite-github-app
Copy link
Copy Markdown

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@pajlada pajlada merged commit b156a5b into runelite:master Feb 25, 2026
2 of 3 checks passed
@Felanbird Felanbird deleted the patch-2 branch February 25, 2026 07:47
@alowaniak
Copy link
Copy Markdown
Contributor

@pajlada do you see perhaps anything in logs or got any other info?
I can't recreate it and afaict it works fine for me:

NVM, in the process of trying to create a video to capture it working for me I was able to recreate it with (music) volume 0.
Apparently happens when (music) volume is 0 and then the plugin is turned on and there's no overridden track.
Will fix it, thanks for catching it.

alowaniak added a commit to alowaniak/music-replacer that referenced this pull request Feb 25, 2026
alowaniak added a commit to alowaniak/plugin-hub that referenced this pull request Feb 25, 2026
- Fixes freezing behavior shown in runelite#10743
Infinitay pushed a commit to Infinitay/plugin-hub that referenced this pull request Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants