Skip to content

Add repository and commit information to bankpricechanges#10810

Merged
riktenx merged 4 commits into
runelite:masterfrom
HuzaifaKafeel:add-bank-price-changes
Mar 17, 2026
Merged

Add repository and commit information to bankpricechanges#10810
riktenx merged 4 commits into
runelite:masterfrom
HuzaifaKafeel:add-bank-price-changes

Conversation

@HuzaifaKafeel
Copy link
Copy Markdown
Contributor

Bank Price Changes

A RuneLite plugin that overlays price change data directly on items in your bank,
and shows a side panel of your top gainers and losers.

Answers the question: "What happened to my bank value? Why is it up/down?!"

Features

  • Bank overlays — each item shows its price change (% or GP) in colour-coded text
  • Side panel — Gainers / Losers tabs, sortable by % or GP, configurable item count
  • Time periods — toggle between different price windows
  • GP threshold — filter out items below a minimum absolute change
  • % threshold — filter out items below a minimum percentage change
  • Placeholder support — optionally include bank placeholders
  • Manual refresh — refresh button with 30-second cooldown to avoid API spam
  • Prices sourced from the OSRS Wiki Prices API

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Mar 1, 2026

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Mar 1, 2026

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@riktenx
Copy link
Copy Markdown
Member

riktenx commented Mar 3, 2026

is there a reason you can't use one of the other versions of these on the hub e.g. https://runelite.net/plugin-hub/show/bank-value-tracker or https://runelite.net/plugin-hub/show/bank-value-changes

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Mar 3, 2026
@HuzaifaKafeel
Copy link
Copy Markdown
Contributor Author

is there a reason you can't use one of the other versions of these on the hub e.g. https://runelite.net/plugin-hub/show/bank-value-tracker or https://runelite.net/plugin-hub/show/bank-value-changes

I've been using both of these, and they have their own limitations which is why I ended up creating my own version.

Bank Value Tracker: Tracks value changes at a tab level. It doesn't answer my fundamental question, "Why is my bank dropping? What item or items are causing it?". I stopped using this long ago because it provided no real value.

Bank Value Changes: Tracks value changes locally, rather than comparing dynamically via the wiki's API. Turning the plugin off and on resets your entire local history. It also displays the changes as percentage only, not gp amounts. Lastly, it doesn't track changes for placeholders.

Features unique to Bank Price Changes:

  • Dynamically compares price changes using the wiki's API, with rate limiting so users cant hammer the endpoint
  • Can display changes in %age, gp, or both
  • Toggle to track placeholders if you want
  • A panel on the side to show the top 5 or 10 items which gained the most, and lost the most. Can toggle between %age or gp. This directly answers the question: "What items are causing my bank to fluctuate?"

@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Mar 3, 2026
@riktenx
Copy link
Copy Markdown
Member

riktenx commented Mar 3, 2026

  • don't use Thread.interrupt
  • don't use latch.await to synchronize a bunch of async requests, you'll want something like CompletableFuture.allOf

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Mar 3, 2026
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Mar 4, 2026
@HuzaifaKafeel
Copy link
Copy Markdown
Contributor Author

  • don't use Thread.interrupt
  • don't use latch.await to synchronize a bunch of async requests, you'll want something like CompletableFuture.allOf

Done

@HuzaifaKafeel
Copy link
Copy Markdown
Contributor Author

@riktenx is there anything else that's blocking this merge?

@riktenx riktenx merged commit 1728407 into runelite:master Mar 17, 2026
2 of 3 checks passed
CCatRS pushed a commit to CCatRS/plugin-hub that referenced this pull request Apr 2, 2026
* Add repository and commit information to bankpricechanges

* Update commit hash in bankpricechanges plugin

* Update bankpricechanges

* Update bankpricechanges
Lexer747 pushed a commit to Lexer747/plugin-hub that referenced this pull request Apr 17, 2026
* Add repository and commit information to bankpricechanges

* Update commit hash in bankpricechanges plugin

* Update bankpricechanges

* Update bankpricechanges
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants