Skip to content

lending-tracker: add relay sync, update README#10872

Merged
riktenx merged 3 commits into
runelite:masterfrom
Guess34:master
Mar 16, 2026
Merged

lending-tracker: add relay sync, update README#10872
riktenx merged 3 commits into
runelite:masterfrom
Guess34:master

Conversation

@Guess34
Copy link
Copy Markdown
Contributor

@Guess34 Guess34 commented Mar 4, 2026

  • Added WebSocket relay for cross-machine group sync
  • Connection status indicator in panel
  • HMAC-SHA256 message signing for sync security
  • Improved invite dialog UX
  • Updated README to reflect actual features

- Added WebSocket relay for cross-machine group sync
- Connection status indicator in panel
- HMAC-SHA256 message signing for sync security
- Improved invite dialog UX
- Updated README to reflect actual features
@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Mar 4, 2026

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Mar 4, 2026

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@riktenx
Copy link
Copy Markdown
Member

riktenx commented Mar 8, 2026

Plugins that did not launch with them cannot add new networking calls to 3rd-party services without doing the following

  • making the features opt-in (disabled by default)
  • setting a warning on the corresponding @ConfigItem that toggles the feature: This feature submits your IP address to a 3rd-party server not controlled or verified by RuneLite developers.

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Mar 8, 2026
@Guess34
Copy link
Copy Markdown
Contributor Author

Guess34 commented Mar 8, 2026

understood ill set those changes.

@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Mar 8, 2026
@Felanbird Felanbird added the waiting for author waiting for the pr author to make changes or respond to questions label Mar 8, 2026
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Mar 8, 2026
@riktenx
Copy link
Copy Markdown
Member

riktenx commented Mar 11, 2026

there is an actual warning field on @ConfigItem that you need to set, if done properly you should see a dialog popup when you interact with the control

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Mar 11, 2026
also removed ground items action (unused)
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Mar 12, 2026
@Guess34
Copy link
Copy Markdown
Contributor Author

Guess34 commented Mar 12, 2026

fixed the warning, i thought it was on there, i missed it when i added it. i also took this chance to remove ground items action too since it was adding massive clutter to menu.

@riktenx riktenx merged commit 19a51ed into runelite:master Mar 16, 2026
2 of 3 checks passed
CCatRS pushed a commit to CCatRS/plugin-hub that referenced this pull request Apr 2, 2026
* lending-tracker: add relay sync, update README

- Added WebSocket relay for cross-machine group sync
- Connection status indicator in panel
- HMAC-SHA256 message signing for sync security
- Improved invite dialog UX
- Updated README to reflect actual features

* sync warning and set false fix

* Added warning popup

also removed ground items action (unused)
Lexer747 pushed a commit to Lexer747/plugin-hub that referenced this pull request Apr 17, 2026
* lending-tracker: add relay sync, update README

- Added WebSocket relay for cross-machine group sync
- Connection status indicator in panel
- HMAC-SHA256 message signing for sync security
- Improved invite dialog UX
- Updated README to reflect actual features

* sync warning and set false fix

* Added warning popup

also removed ground items action (unused)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants