update chatbox-scroll-to-zoom#10936
Merged
Merged
Conversation
|
|
|
Internal use only: Reviewer details Maintainer details |
iProdigy
approved these changes
Mar 8, 2026
CCatRS
pushed a commit
to CCatRS/plugin-hub
that referenced
this pull request
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prior to this change, hardcoded integer values were used for the
arguments passed to the scroll script. with a recent change to
runelite / osrs, the script no longer scrolled. some investigation
revealed that these arguments are the unpacked values of the
CHATSCROLLBAR and SCROLLAREA InterfaceID's (these are defined in
hex in runelite, so it was a bit tough to find what these values
corresponded to), and these values changed with a recent update.
with this change, those InterfaceID's are passed as arguments to
the scroll script instead of hardcoded values, so it should be resilient
to future InterfaceID changes.
tested this with the most recent version of runelite.