Skip to content

Odablock Sound Plugin Update#10978

Merged
abextm merged 4 commits into
runelite:masterfrom
LogicalSoIutions:odablock-update
Mar 10, 2026
Merged

Odablock Sound Plugin Update#10978
abextm merged 4 commits into
runelite:masterfrom
LogicalSoIutions:odablock-update

Conversation

@LogicalSoIutions
Copy link
Copy Markdown
Contributor

image

Making this PR on behalf of @DapperMickie as he is unable to do it via mobile and is unable to get to a PC to handle the update

Removed my Shop-Block plugin from this PR so it is solely just an update for the sound plugin.

He will also be commenting below to confirm - commit hash is tied to his repo as per usual.

Shop-Block is a plugin that prevents users from selling to shops when they click an item based on a set value and value type.
Making this commit on behalf of @DapperMickie per his request.
@runelite-github-app
Copy link
Copy Markdown

Includes changes by non-author

odablock: 2935696564e87db763b7e5644fb29901e7c9d0e5..77e3b66914dc6c6725378887aa6f6b9e6898d226

@runelite-github-app
Copy link
Copy Markdown

Feedback:

  • Use of javax.sound.sampled.LineUnavailableException is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.UnsupportedAudioFileException is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead

A new scan will be automatically performed on the next push to the PR branch.


Internal use only: Reviewer details Maintainer details

@Felanbird
Copy link
Copy Markdown
Contributor

confirmed in discord

@abextm abextm merged commit 4a111b3 into runelite:master Mar 10, 2026
2 of 3 checks passed
@LogicalSoIutions LogicalSoIutions deleted the odablock-update branch March 14, 2026 23:48
@LogicalSoIutions LogicalSoIutions restored the odablock-update branch March 14, 2026 23:48
CCatRS pushed a commit to CCatRS/plugin-hub that referenced this pull request Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants