Skip to content

Update attacktimer#11024

Merged
riktenx merged 3 commits into
runelite:masterfrom
Lexer747:master
Mar 16, 2026
Merged

Update attacktimer#11024
riktenx merged 3 commits into
runelite:masterfrom
Lexer747:master

Conversation

@Lexer747
Copy link
Copy Markdown
Contributor

@Lexer747 Lexer747 commented Mar 12, 2026

This is my first update as a maintainer of attacktimer.

  • Fixes Harmonised Staff (weapon ID and animation IDs changed)
  • Makes halibut and gnome foods work as "fast foods"
  • Fixes Eye Of Ayak
  • Fixes manual casting in PvP
  • Fixes hunter and tick manipulation triggering the timer.

Let me know if there's any due process I followed incorrectly, I think I followed readme#updating-a-plugin correctly 😅

cc @ngraves95

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Mar 12, 2026

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Mar 12, 2026

Internal use only: Reviewer details Maintainer details

@riktenx
Copy link
Copy Markdown
Member

riktenx commented Mar 13, 2026

@ngraves95 do you approve this author change/patch?

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Mar 13, 2026
@ngraves95
Copy link
Copy Markdown
Contributor

@Lexer747 can you update to 493f45824ab77330e053cf7aca3f80e65f811a97 to pull in the latest eat changes?

@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Mar 15, 2026
@Lexer747
Copy link
Copy Markdown
Contributor Author

@Lexer747 can you update to 493f45824ab77330e053cf7aca3f80e65f811a97 to pull in the latest eat changes?

I also included the animation data changes (ngraves95/attacktimer#117) since I need that for my current chin pet hunt 😸.


Oh I've see some other plugins in the hub have an authors tag e.g. authors=RS117,sosodev,ahooder, I've added that to the attack timer aswell in this PR. Is that correct or should I raise it as a separate pull request?

@pajlada
Copy link
Copy Markdown
Contributor

pajlada commented Mar 15, 2026

I've added that to the attack timer aswell in this PR. Is that correct or should I raise it as a separate pull request?

That's fine to keep in this PR, assuming @ngraves95 is fine to let you submit updates to the plugin without his sign-off.

@ngraves95
Copy link
Copy Markdown
Contributor

commit 20f7bcdd67323bb4f3b5f1b6cd6c49ffdfda947d LGTM, approved

@riktenx riktenx merged commit 472e2a2 into runelite:master Mar 16, 2026
3 checks passed
CCatRS pushed a commit to CCatRS/plugin-hub that referenced this pull request Apr 2, 2026
* update attacktimer

* Include new eat changes

* hunter fixes and authors tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants