Skip to content

Add custom death sounds plugin repository#11034

Closed
Tuomar2 wants to merge 2 commits into
runelite:masterfrom
Tuomar2:custom-death-sounds
Closed

Add custom death sounds plugin repository#11034
Tuomar2 wants to merge 2 commits into
runelite:masterfrom
Tuomar2:custom-death-sounds

Conversation

@Tuomar2
Copy link
Copy Markdown

@Tuomar2 Tuomar2 commented Mar 13, 2026

Plugin adds custom sound effects for player and NPC deaths.
Displays custom text messages when a player or NPC dies.
Enhances death events with more noticeable and entertaining feedback.

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Mar 13, 2026

@runelite-github-app
Copy link
Copy Markdown

Feedback:

  • Use of javax.sound.sampled.FloatControl is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.FloatControl.setValue is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.FloatControl.getMinimum is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.Clip.start is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.AudioSystem.getClip is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.Control$Type is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.FloatControl$Type.MASTER_GAIN is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.Clip is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.FloatControl$Type is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.AudioSystem is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.Clip.getControl is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.Clip.open is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.AudioSystem.getAudioInputStream is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.Control is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead

A new scan will be automatically performed on the next push to the PR branch.


Internal use only: Reviewer details Maintainer details

@riktenx
Copy link
Copy Markdown
Member

riktenx commented May 13, 2026

you will need to provide attribution for the sound files here such that we can verify they are licenseable

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label May 13, 2026
@riktenx
Copy link
Copy Markdown
Member

riktenx commented May 28, 2026

closing because the above has not been addressed

@riktenx riktenx closed this May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin added size-0 waiting for author waiting for the pr author to make changes or respond to questions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants