Skip to content

Add Shared Boss Uniques plugin#11086

Open
Totalchi wants to merge 9 commits into
runelite:masterfrom
Totalchi:add-shared-boss-uniques
Open

Add Shared Boss Uniques plugin#11086
Totalchi wants to merge 9 commits into
runelite:masterfrom
Totalchi:add-shared-boss-uniques

Conversation

@Totalchi
Copy link
Copy Markdown

Summary

Adds the Shared Boss Uniques RuneLite plugin to Plugin Hub.

This plugin uploads boss collection-log data and shows shared unique progress for participating group members.

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Mar 15, 2026

@rmobis
Copy link
Copy Markdown
Contributor

rmobis commented Mar 15, 2026

Not a RuneLite reviewer, but your plugin repository seems to be private.

@Totalchi
Copy link
Copy Markdown
Author

Totalchi commented Mar 15, 2026 via email

@Totalchi
Copy link
Copy Markdown
Author

@Felanbird Felanbird closed this Mar 15, 2026
@Felanbird Felanbird reopened this Mar 15, 2026
@Felanbird
Copy link
Copy Markdown
Contributor

This crashes the build script, probably because your .gitignore file seems to be gone, and because of that you have committed the .gradle folder.

@Felanbird Felanbird added the waiting for author waiting for the pr author to make changes or respond to questions label Mar 15, 2026
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Mar 15, 2026
@Totalchi
Copy link
Copy Markdown
Author

Hey, Thank you for ur time, im fixing it now, first time making a plugin sorry :)

Just so u know a bit what it is , im making something so group ironmen can easily check what they have unlocked a group itemwise, right now we never really know how much zenytes we have how many barrows or tassets etc, inf uture i can build it out

@Totalchi
Copy link
Copy Markdown
Author

Fixed. The plugin repository is public, the standalone plugin tree now includes .gitignore, the tracked .gradle directory has been removed, and this PR now points to commit 5d09dac27a0ef6dd09c4362d6f4f0e9c1a797703.

@Totalchi
Copy link
Copy Markdown
Author

Fixed the deprecated Gson usage. The plugin now injects RuneLite's Gson instead of constructing fresh instances, and this PR now points to commit a49f6764508fca185561557a771c5b6d68ba815a.

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Mar 15, 2026

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@Totalchi
Copy link
Copy Markdown
Author

Fixed. enabledByDefault = false has been removed from the plugin descriptor, and this PR now points to commit 6f423e3d374d2d33e0495f18668bae69f68a2ca6.

@Totalchi
Copy link
Copy Markdown
Author

How can i see what i need to fix?

@cdfisher
Copy link
Copy Markdown
Contributor

Your build is passing, you just need to wait for a reviewer to review your submission. It anything needs to be changed, they'll tell you.

@Totalchi
Copy link
Copy Markdown
Author

Your build is passing, you just need to wait for a reviewer to review your submission. It anything needs to be changed, they'll tell you.

Thanks zir

@Totalchi
Copy link
Copy Markdown
Author

Its been 3 weeks, does someone look at this?

@Felanbird
Copy link
Copy Markdown
Contributor

Its been 3 weeks, does someone look at this?

The new plugin queue is extremely bloated due to all the AI submissions, 3 weeks is unfortunately not long anymore

@Totalchi
Copy link
Copy Markdown
Author

how about 2 months? XD whats the average time?

@Felanbird
Copy link
Copy Markdown
Contributor

how about 2 months?

Ironically enough you once again asked at 3 weeks, since you updated this PR with claude 3 weeks ago.

@Totalchi
Copy link
Copy Markdown
Author

XD i see well i give up, i"ll leave it at this either it gets accepted or not i'll see , thanks

@riktenx
Copy link
Copy Markdown
Member

riktenx commented May 17, 2026

use of Thread interrupt is not allowed

@riktenx
Copy link
Copy Markdown
Member

riktenx commented May 17, 2026

also don't use the java http client, inject and use runelite's okhttpclient instead

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label May 17, 2026
@Totalchi
Copy link
Copy Markdown
Author

thank you! @riktenx

@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label May 18, 2026
@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label May 19, 2026
@riktenx
Copy link
Copy Markdown
Member

riktenx commented May 19, 2026

i see you made the changes but you didn't update the commit hash here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin added size-0 waiting for author waiting for the pr author to make changes or respond to questions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants