Skip to content

Add Bank-POH-searcher#11166

Merged
runelite-github-app[bot] merged 8 commits into
runelite:masterfrom
Wozak-1:wheresmystuff
Apr 26, 2026
Merged

Add Bank-POH-searcher#11166
runelite-github-app[bot] merged 8 commits into
runelite:masterfrom
Wozak-1:wheresmystuff

Conversation

@Wozak-1
Copy link
Copy Markdown
Contributor

@Wozak-1 Wozak-1 commented Mar 21, 2026

Second attempt at publishing "Where's my stuff." A convient bank snapshot searcher and POH snapshot searcher. Intend on adding more in the future, like STASH locations.

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Mar 21, 2026

@Felanbird
Copy link
Copy Markdown
Contributor

Please don't open a new pull request just because the build is failing, just update the existing PR with the fixed commit.

cc step 8 of the build guide

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Mar 21, 2026

This plugin requires reviews from Plugin Hub reviewers. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@Wozak-1
Copy link
Copy Markdown
Contributor Author

Wozak-1 commented Mar 21, 2026

Please don't open a new pull request just because the build is failing, just update the existing PR with the fixed commit.

cc step 8 of the build guide

Oh sorry.I am new to contributing.

@raiyni
Copy link
Copy Markdown
Member

raiyni commented Mar 21, 2026

I don't understand this comment because UIM's use it to track their piles and such

#11165 (comment)

it is also very clearly designed to be used for whatever account you are signed in on https://runelite.net/plugin-hub/show/dude-wheres-my-stuff

it also definitely has poh abilities https://github.com/Thource/dude-wheres-my-stuff/blob/main/src/main/java/dev/thource/runelite/dudewheresmystuff/playerownedhouse/PlayerOwnedHouseStorage.java

Have you actually tried using this plugin?

It even has a bank tracker https://github.com/Thource/dude-wheres-my-stuff/blob/main/src/main/java/dev/thource/runelite/dudewheresmystuff/world/Bank.java

@Wozak-1
Copy link
Copy Markdown
Contributor Author

Wozak-1 commented Mar 21, 2026

I don't understand this comment because UIM's use it to track their piles and such

#11165 (comment)

it is also very clearly designed to be used for whatever account you are signed in on https://runelite.net/plugin-hub/show/dude-wheres-my-stuff

it also definitely has poh abilities https://github.com/Thource/dude-wheres-my-stuff/blob/main/src/main/java/dev/thource/runelite/dudewheresmystuff/playerownedhouse/PlayerOwnedHouseStorage.java

Have you actually tried using this plugin?

It even has a bank tracker https://github.com/Thource/dude-wheres-my-stuff/blob/main/src/main/java/dev/thource/runelite/dudewheresmystuff/world/Bank.java

I don’t think I said anything confusing in my comment. I haven’t heard of it before that comment. I tried using it and it didn’t seem obvious to me in about 5 seconds nor its description that it had that functionality. It also says in the description that it tracks across accounts.

That being said (assuming you’re correct because I didn’t open it still. Not at home rn), I stand corrected.

@Wozak-1
Copy link
Copy Markdown
Contributor Author

Wozak-1 commented Mar 21, 2026

Closing as functions are eclipsed by "Dude, Where's my stuff?"

@Wozak-1 Wozak-1 closed this Mar 21, 2026
@Wozak-1 Wozak-1 reopened this Mar 21, 2026
@Wozak-1
Copy link
Copy Markdown
Contributor Author

Wozak-1 commented Mar 21, 2026

I have used Dude where's my stuff and i like the simplicity of mine better, so i am still going to try to put it up

@Wozak-1 Wozak-1 changed the title Wheresmystuff Add Wheresmystuff Mar 21, 2026
@pajlada
Copy link
Copy Markdown
Contributor

pajlada commented Mar 21, 2026

are you open to changing the name of your plugin? i feel like the naming can be confusing

not commenting from a reviewer's standpoint, just a user

@Wozak-1
Copy link
Copy Markdown
Contributor Author

Wozak-1 commented Mar 22, 2026

are you open to changing the name of your plugin? i feel like the naming can be confusing

not commenting from a reviewer's standpoint, just a user

I am definitely open to changing the name. Honestly after finding out about that other plugin i wanted to but can't think of any that arent super lengthy. Do you have any suggestions?

For now i have called it Bank and POH searcher

@Wozak-1 Wozak-1 marked this pull request as draft March 22, 2026 14:04
@Wozak-1 Wozak-1 changed the title Add Wheresmystuff Add Bank-POH-searcher Mar 22, 2026
editing the name of the plugin to fix confusion with similar plugin
@Wozak-1 Wozak-1 marked this pull request as ready for review March 22, 2026 14:11
@Wozak-1
Copy link
Copy Markdown
Contributor Author

Wozak-1 commented Mar 29, 2026

Added equipment comparison to allow for comparison between equipment worn and that in bank. Also Added sorting functionality to sort by recent. Helpful for PVM and PVP when dumping loot into bank, you can see what that loot was.

@riktenx
Copy link
Copy Markdown
Member

riktenx commented Apr 26, 2026

Pull requests which automatically pass the "RuneLite Plugin Hub Checks" and use the standard build type are now eligible for automated review. If your plugin uses the standard build.gradle script, consider adding build=standard to your runelite-plugin.properties file and update this PR.

@runelite-github-app runelite-github-app Bot merged commit 68a25e5 into runelite:master Apr 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants