Skip to content

Update compact-orbs to v1.7.5#11355

Merged
Alexsuperfly merged 3 commits into
runelite:masterfrom
its-cue:update-compact-orbs
Apr 13, 2026
Merged

Update compact-orbs to v1.7.5#11355
Alexsuperfly merged 3 commits into
runelite:masterfrom
its-cue:update-compact-orbs

Conversation

@its-cue
Copy link
Copy Markdown
Contributor

@its-cue its-cue commented Apr 3, 2026

  • overhaul overlay orb creation & handling
  • add functional Hp, Prayer, Run & Special orbs to the minimap overlay

bugfixes:

  • limit children hiding in setHidden to the Compass menu options

preview:
compact-orbs-mapoverlay

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Apr 3, 2026

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Apr 3, 2026

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@Alexsuperfly
Copy link
Copy Markdown
Contributor

use of client.menuAction is not allowed, this feature will need to be removed

@Alexsuperfly Alexsuperfly added the waiting for author waiting for the pr author to make changes or respond to questions label Apr 8, 2026
@its-cue
Copy link
Copy Markdown
Contributor Author

its-cue commented Apr 8, 2026

thanks for the review 😢, for clarity

  1. is the use of menuAction in general not allowed, or just the way it was used here (for the data orbs, or all orbs including xp/logout/worldmap)?
  2. would this be acceptable? widget.setOnOpListener(Script.TOPLEVEL_SIDEBUTTON_OP, OPINDEX0, 1131, 10), //logout x, set side panel tab to logout

@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Apr 8, 2026
@Alexsuperfly
Copy link
Copy Markdown
Contributor

client.menuaction just cant be used, setting an OnOpListener is acceptable

@Alexsuperfly Alexsuperfly added the waiting for author waiting for the pr author to make changes or respond to questions label Apr 9, 2026
@its-cue
Copy link
Copy Markdown
Contributor Author

its-cue commented Apr 9, 2026

thanks again - since i'm going to scrap this, should i close this and make a new PR that removes pre-existing uses?

@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Apr 9, 2026
@Alexsuperfly
Copy link
Copy Markdown
Contributor

updating this is fine, unless you are going to take a while to do so, then id say close and open when youre actually ready

@Alexsuperfly Alexsuperfly merged commit e402e0f into runelite:master Apr 13, 2026
2 of 3 checks passed
@its-cue its-cue deleted the update-compact-orbs branch April 13, 2026 19:44
Infinitay pushed a commit to Infinitay/plugin-hub that referenced this pull request Apr 26, 2026
@Scoliox
Copy link
Copy Markdown

Scoliox commented May 2, 2026

use of client.menuAction is not allowed, this feature will need to be removed

Seriously lame that this feature isn't allowed when in actual reality all it did was allow for the plugin maker to attach the XP orb and the minimap orb to the minimap. Makes genuinely zero sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants