Skip to content

Updated BA PBs#11404

Merged
iProdigy merged 3 commits into
runelite:masterfrom
CCatRS:Barbarians-Assault-Personal-Bests
Apr 9, 2026
Merged

Updated BA PBs#11404
iProdigy merged 3 commits into
runelite:masterfrom
CCatRS:Barbarians-Assault-Personal-Bests

Conversation

@CCatRS
Copy link
Copy Markdown
Contributor

@CCatRS CCatRS commented Apr 7, 2026

Fixed stale executor issue. When the plugin shutdown was being called, the executor was shutdown. But a new one was never created on startup. This ensures a valid executor is always available.

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Apr 7, 2026

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Apr 7, 2026

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@iProdigy
Copy link
Copy Markdown
Member

iProdigy commented Apr 8, 2026

why not just inject runelite's executor? better yet, you can avoid blocking Call#execute calls via enqueue + CompletableFuture

@CCatRS
Copy link
Copy Markdown
Contributor Author

CCatRS commented Apr 8, 2026

why not just inject runelite's executor? better yet, you can avoid blocking Call#execute calls via enqueue + CompletableFuture

Thanks. Switched to RuneLite’s executor. Kept execute() for now since this isn’t high frequency, but happy to refactor to enqueue if needed.

@iProdigy iProdigy merged commit 4b09ec3 into runelite:master Apr 9, 2026
2 of 3 checks passed
Infinitay pushed a commit to Infinitay/plugin-hub that referenced this pull request Apr 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants