Update project-xeric

[Septem151]

The diff is large, but the bulk of it is image removals since those are now served via the backend server.

I tried to keep changes as minimal and as easy to read as possible. There was quite a lot that needed to be changed.

2.1.0

The long-awaited leaderboards are finally here! This update to the plugin will track and submit
your progress to the Zeah Ironmen clan leaderboards, which you can view at https://projectxeric.com.
Some other general improvements were made so that tasks and ranks can be updated on the fly!

Features

• Player data is submitted to leaderboards by default with toggle to disable data submission.
  Non-irons and accounts with 0 Xeric Points never submit player data.
• Leaderboard panel now includes link to the official Zeah Ironmen clan leaderboards.

Hotfixes

• Load time lag at startup fixed, login should be smoother.

[runelite-github-app]

project-xeric: 6fe1d072a70df531f3deb59de580272a0ccb623f..9553e8230a4ae1702f0e7e14887332586f4eff7f

[runelite-github-app]

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.

---

Internal use only: Reviewer details Maintainer details

[Felanbird]

I've manually adjusted the size label due to the -3k file deletion, don't push any additional changes to the PR unless requested, or the bot will override the label.

[pajlada]

In your loadIcon function in ImageService.java, please confirm the file you're trying to load the cache from is actually in the cacheDir. something like

Path resolvedPath = Paths.get(cacheDir).resolve(filename).normalize();
if (resolvedPath.startsWith(cacheDir)) {
  // your logic here
}

---

In your deleteDirectory function in ProjectXericPlugin.java, please error out/break if you find a symlink

[Septem151]

@pajlada I beefed up the file IO and switched over all operations to use the Files API. Included checks for symlinks in ImageService's loadIcons, same with deleteDirectory in the main plugin class. Will need to update the size label back to size-l manually it looks like 😄
Here's the diff added for easier viewing if this helps: Septem151/project-xeric@9553e82