Skip to content

Add Final Boss clan plugin#11431

Merged
riktenx merged 5 commits into
runelite:masterfrom
orgonag:master
May 16, 2026
Merged

Add Final Boss clan plugin#11431
riktenx merged 5 commits into
runelite:masterfrom
orgonag:master

Conversation

@orgonag
Copy link
Copy Markdown
Contributor

@orgonag orgonag commented Apr 9, 2026

Plugin: Final Boss

Clan tools for the Final Boss OSRS clan.

Features

  • Clan Verification — Verifies membership via the Wise Old Man API (Group 1055)
  • Drop Logging — Logs valuable drops (1M+ GP) to a shared Supabase database with Row Level Security
  • Discord Notifications — Optional webhook for drop alerts in Discord
  • Looking For Group — Find clan members to group up with (8 activity types, list/grouped views)

Technical Details

  • Uses injected OkHttpClient for all HTTP calls (WOM, Supabase, Discord)
  • All network calls run on background threads via ScheduledExecutorService
  • No reflection, no raw threads, no internal API access
  • Supabase anon key is intentionally public — protected by RLS policies
  • BSD 2-Clause license

Repository

https://github.com/orgonag/fbclan-plugin

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Apr 9, 2026

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Apr 9, 2026

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

Comment thread plugins/fbclan-plugin Outdated
@riktenx
Copy link
Copy Markdown
Member

riktenx commented May 15, 2026

Please add build=standard to runelite-plugin.properties.

@orgonag
Copy link
Copy Markdown
Contributor Author

orgonag commented May 15, 2026

Added build=standard to runelite-plugin.properties and updated the commit hash. Thanks for the review!

@orgonag
Copy link
Copy Markdown
Contributor Author

orgonag commented May 16, 2026

what would be required in order to get the 3rd party database to be reviewed by runelite to drop the warning? There are folks in my clan that would likely not use the plugin because of the warning; wondering if there is 1. a process for review of the 3rd party datavase or 2. any other way to rewrite the plugin with the lfg functionality intact. i dont know how that would even be possible without writing data somewhere

@riktenx
Copy link
Copy Markdown
Member

riktenx commented May 16, 2026

There is no such process, because as the warning states, the server is not controlled by us. Reviewing the database (not sure what that means in this context, if you're talking about the code, verifying the state of the deployment, etc.) does not convey any sort of verification because we don't have sole control over the server and what it's doing at all times.

Essentially the only way to not have that warning is for your plugin to not have that functionality.

@riktenx
Copy link
Copy Markdown
Member

riktenx commented May 16, 2026

FYI I reviewed the rest of your plugin and it was fine but given your question above I'm not sure if you intend to proceed or not, so I'm holding off on merging for now.

@orgonag
Copy link
Copy Markdown
Contributor Author

orgonag commented May 16, 2026

I understand what you have said; that lfg functionality is important but the warning always sours some people. its not a deal breaker thought

I would like to still progress with the merge. thank you

@riktenx riktenx merged commit 9bc0c84 into runelite:master May 16, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants