Add Final Boss clan plugin#11431
Conversation
|
New plugin |
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
|
Please add |
|
Added |
|
what would be required in order to get the 3rd party database to be reviewed by runelite to drop the warning? There are folks in my clan that would likely not use the plugin because of the warning; wondering if there is 1. a process for review of the 3rd party datavase or 2. any other way to rewrite the plugin with the lfg functionality intact. i dont know how that would even be possible without writing data somewhere |
|
There is no such process, because as the warning states, the server is not controlled by us. Reviewing the database (not sure what that means in this context, if you're talking about the code, verifying the state of the deployment, etc.) does not convey any sort of verification because we don't have sole control over the server and what it's doing at all times. Essentially the only way to not have that warning is for your plugin to not have that functionality. |
|
FYI I reviewed the rest of your plugin and it was fine but given your question above I'm not sure if you intend to proceed or not, so I'm holding off on merging for now. |
|
I understand what you have said; that lfg functionality is important but the warning always sours some people. its not a deal breaker thought I would like to still progress with the merge. thank you |
Plugin: Final Boss
Clan tools for the Final Boss OSRS clan.
Features
Technical Details
OkHttpClientfor all HTTP calls (WOM, Supabase, Discord)ScheduledExecutorServiceRepository
https://github.com/orgonag/fbclan-plugin