Skip to content

Update modern-chat: Bug fix (issue 24)#11508

Merged
iProdigy merged 3 commits into
runelite:masterfrom
BenDol:fix/24
Apr 15, 2026
Merged

Update modern-chat: Bug fix (issue 24)#11508
iProdigy merged 3 commits into
runelite:masterfrom
BenDol:fix/24

Conversation

@BenDol
Copy link
Copy Markdown
Contributor

@BenDol BenDol commented Apr 14, 2026

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Apr 14, 2026 •
edited
Loading

modern-chat: b1954529f648fa40bc26f9ad913b9a8dc3a8ed9c..b6fbbbb5bfdc4c2bbdf0812c448752f8af8d7659

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Apr 14, 2026 •
edited
Loading

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.

Internal use only: Reviewer details Maintainer details

@Felanbird
Copy link
Copy Markdown
Contributor

Felanbird commented Apr 14, 2026 •
edited
Loading

What's happening here, why are you submitting us two three* different changes that conflict each other?

@BenDol
Copy link
Copy Markdown
Contributor Author

BenDol commented Apr 15, 2026 •
edited
Loading

What's happening here, why are you submitting us two three* different changes that conflict each other?

There shouldn't be any conflicts in these changes, where are you seeing that? These are 3 different bug fixes that are independent of each other.

@tylerwgrass
Copy link
Copy Markdown
Member

tylerwgrass commented Apr 15, 2026

Merging one fix causes the branches to conflict, as should be expected.

@iProdigy iProdigy added the waiting for author waiting for the pr author to make changes or respond to questions label Apr 15, 2026
@BenDol
Copy link
Copy Markdown
Contributor Author

BenDol commented Apr 15, 2026 •
edited
Loading

Merging one fix causes the branches to conflict, as should be expected.

I see, I forgot we're just passing the commit sha in the file, I was thinking my changes were clashing.

EDIT: I'll just do fixes one at a time next time I suppose.

@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Apr 15, 2026
@iProdigy iProdigy added the waiting for author waiting for the pr author to make changes or respond to questions label Apr 15, 2026
@runelite-github-app runelite-github-app Bot removed waiting for author waiting for the pr author to make changes or respond to questions size-s labels Apr 15, 2026
@BenDol BenDol closed this Apr 15, 2026
@BenDol BenDol reopened this Apr 15, 2026
@iProdigy iProdigy merged commit 4191a9d into runelite:master Apr 15, 2026
4 of 5 checks passed
Infinitay pushed a commit to Infinitay/plugin-hub that referenced this pull request Apr 26, 2026
@BenDol @Infinitay
Update modern-chat (runelite#11508)
c8cdff8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iProdigy iProdigy iProdigy approved these changes

Assignees

No one assigned

Labels

plugin change size-s

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GIM Group Chat Channel Issues

4 participants

@BenDol @Felanbird @tylerwgrass @iProdigy