update tasks-tracker plugin for league 6 dbrow support#11518
Merged
Conversation
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
Infinitay
pushed a commit
to Infinitay/plugin-hub
that referenced
this pull request
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
TaskSourceType(STRUCT/DBROW) so tasks can be loaded from cache DB rows, not just structs. Needed because Jagex is moving L6 onto DB tables.Changes
Core
TaskSourceTypeenum discriminator on task typesTaskFromDbRowreads columns viaclient.getDBTableField(dbRowId, colIdx, 0);intParamMap/stringParamMapvalues are column indices in this modeITaskinterface;TaskServicebranches on source typeTaskFromDbRow.getVarpIndex()returnssortId(matches cs2's flat-index completion convention)Safety fixes exposed by the new path
TaskFromDbRow.loadData: per-column try/catch. Sparse columns throw when queried on rows without them; previously one bad column killed the task load and cascaded to a type-switch failure.processTaskStatus: bounds-checktaskVarps.get(varbitIndex)beforegetVarpValue. Prevents per-tick IOOB when sortIds exceed the varp range.addSortedIndexcomparators: null int params coerce to 0, strings usenullsLast. Without this, sort throws mid-thenComposeandtaskTypeChanged=truenever fires - tasks load but panel never redraws.getTaskIndex: null-guarded.containsKeydoesn't protect against a null value, andaddSortedIndex's put-null-then-replace race can strand a null if the sort throws.TaskPanel: null-guardtask.getDescription()so missing descriptions render empty instead of "null".Pre-existing bug uncovered
FilterService.getGlobalFilterByKeydoes blocking HTTP on first call. Previously masked because every task type hadGLOBALfilters, sostartUp()'s off-EDTsetTaskTypealways warmed the cache. A task type with empty filters leaves it cold; next EDT-driven switch to a type with GLOBAL filters throwsBlocking network calls are not allowed on the event dispatch threadand NPEs on the null return.FilterService.preloadFilterConfigs()called fromstartUp()viarunAsync, independent of saved task type.setTaskTypenull-guardsglobalFilterConfigas a belt-and-braces for preload failure.