fix: reset Mark of Darkness reminder on player death (#17)#11528
Merged
Conversation
fix: reset Mark of Darkness reminder on player death (#17) The buff is lost when the player dies, but the timer continued counting down without showing the recast reminder. - Track whether the Mark of Darkness buff is active via `isMarkActive` in the overlay - Add `resetOnDeath()` to the overlay which immediately triggers the recast reminder if the buff was active - Subscribe to `ActorDeath` in the plugin and call `resetOnDeath()` when the local player dies
|
Internal use only: Reviewer details Maintainer details |
Infinitay
pushed a commit
to Infinitay/plugin-hub
that referenced
this pull request
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: reset Mark of Darkness reminder on player death (#17)
The buff is lost when the player dies, but the timer continued
counting down without showing the recast reminder.
isMarkActivein the overlay
resetOnDeath()to the overlay which immediately triggers therecast reminder if the buff was active
ActorDeathin the plugin and callresetOnDeath()when the local player dies