Skip to content

Create Bank-Skill-Sorting#11536

Merged
runelite-github-app[bot] merged 15 commits into
runelite:masterfrom
Frailrain:master
May 15, 2026
Merged

Create Bank-Skill-Sorting#11536
runelite-github-app[bot] merged 15 commits into
runelite:masterfrom
Frailrain:master

Conversation

@Frailrain
Copy link
Copy Markdown
Contributor

A bank tag plugin that attempts to automatically sort a users bank by placing items in tabs relevant to skills

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Apr 15, 2026

@Frailrain Frailrain requested a review from a team as a code owner April 15, 2026 22:54
@tylerwgrass
Copy link
Copy Markdown
Member

You should not be deleting the license file

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Apr 15, 2026

This plugin requires reviews from Plugin Hub reviewers. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@Frailrain
Copy link
Copy Markdown
Contributor Author

You should not be deleting the license file

I think I added it to the wrong repo at first so that's why I deleted it and put it in the other one

@riktenx
Copy link
Copy Markdown
Member

riktenx commented Apr 26, 2026

Pull requests which automatically pass the "RuneLite Plugin Hub Checks" and use the standard build type are now eligible for automated review. If your plugin uses the standard build.gradle script, consider adding build=standard to your runelite-plugin.properties file and update this PR.

@Frailrain
Copy link
Copy Markdown
Contributor Author

Added build=standard to runelite-plugin.properties and switched to the canonical example-plugin build.gradle. CI is green. Let me know if anything else is needed!

@Felanbird
Copy link
Copy Markdown
Contributor

You're still deleting the license file.

@Felanbird Felanbird added the waiting for author waiting for the pr author to make changes or respond to questions label May 13, 2026
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label May 14, 2026
@Frailrain
Copy link
Copy Markdown
Contributor Author

New commit with the correct hash that has the license file. I'm pretty sure I got this correct this time, please let me know if I missed anything else. This is my first time doing anything like this and I'm trying my best haha 😅

@Felanbird
Copy link
Copy Markdown
Contributor

You are deleting OUR license for this github repo, in your PR.
image

@Felanbird Felanbird added the waiting for author waiting for the pr author to make changes or respond to questions label May 14, 2026
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label May 14, 2026
@Frailrain
Copy link
Copy Markdown
Contributor Author

Oh my god I see it now. I'm sorry about that, I have readded the license file (copied from the main plugin hub repo). Thank you for your patience with me.

@riktenx
Copy link
Copy Markdown
Member

riktenx commented May 15, 2026

you are still modifying it
image

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label May 15, 2026
@riktenx
Copy link
Copy Markdown
Member

riktenx commented May 15, 2026

if https://github.com/runelite/plugin-hub/pull/11536/changes shows any files other than your manifest file then this submission is invalid and cannot be reviewed until addressed

@runelite-github-app runelite-github-app Bot removed waiting for author waiting for the pr author to make changes or respond to questions size-0 labels May 15, 2026
@Frailrain
Copy link
Copy Markdown
Contributor Author

After much finagling and eventually just doing it locally I believe I have it exactly as you have expected. Thank you for your patience with me one this, I am new to all this and it is a bit overwhelming. Please let me know if you need anything else from me

@runelite-github-app runelite-github-app Bot merged commit 3fa5efc into runelite:master May 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants