Skip to content

Update unmutedjingles 0.23#11549

Merged
iProdigy merged 4 commits into
runelite:masterfrom
hootisman:unmutedjingles
Apr 18, 2026
Merged

Update unmutedjingles 0.23#11549
iProdigy merged 4 commits into
runelite:masterfrom
hootisman:unmutedjingles

Conversation

@hootisman
Copy link
Copy Markdown
Contributor

Added leagues task + relic sounds

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Apr 16, 2026

@tylerwgrass
Copy link
Copy Markdown
Member

Please resolve the conflicts

@tylerwgrass tylerwgrass added the waiting for author waiting for the pr author to make changes or respond to questions label Apr 17, 2026
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Apr 17, 2026
@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Apr 17, 2026

Feedback:

  • Use of javax.sound.sampled.AudioSystem.getLine is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.FloatControl.setValue is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.SourceDataLine.open is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.SourceDataLine.start is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.BooleanControl$Type is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.SourceDataLine.stop is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.Control$Type is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.Line$Info is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.BooleanControl.setValue is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.DataLine$Info.<init> is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.BooleanControl is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.AudioFormat is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.Line is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.FloatControl is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.DataLine$Info is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.SourceDataLine.getControl is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.SourceDataLine.flush is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.SourceDataLine.close is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.DataLine is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.SourceDataLine.getMicrosecondPosition is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.AudioFormat.<init> is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.FloatControl$Type.MASTER_GAIN is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.SourceDataLine.write is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.BooleanControl$Type.MUTE is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.FloatControl$Type is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.AudioSystem is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.SourceDataLine is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.SourceDataLine.drain is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.Control is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead

A new scan will be automatically performed on the next push to the PR branch.


Internal use only: Reviewer details Maintainer details

@iProdigy
Copy link
Copy Markdown
Member

@hootisman
Copy link
Copy Markdown
Contributor Author

No that isnt intentional i'll fix real quick

@iProdigy iProdigy added the waiting for author waiting for the pr author to make changes or respond to questions label Apr 18, 2026
@runelite-github-app runelite-github-app Bot added size-m and removed waiting for author waiting for the pr author to make changes or respond to questions size-s labels Apr 18, 2026
@iProdigy iProdigy merged commit 6e69c91 into runelite:master Apr 18, 2026
2 of 3 checks passed
@hootisman hootisman deleted the unmutedjingles branch April 18, 2026 16:08
Infinitay pushed a commit to Infinitay/plugin-hub that referenced this pull request Apr 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants