Skip to content

Add Aggro Tag plugin#11616

Merged
runelite-github-app[bot] merged 12 commits into
runelite:masterfrom
Bellefeu:master
May 24, 2026
Merged

Add Aggro Tag plugin#11616
runelite-github-app[bot] merged 12 commits into
runelite:masterfrom
Bellefeu:master

Conversation

@Bellefeu
Copy link
Copy Markdown
Contributor

Adds the Aggro Tag plugin.

Shows a colored name tag above NPCs that will attack the player on
sight. Features include: Wiki-sourced aggression data, max hit display
colored by attack style, aggression radius with Line of Sight,
10-minute tolerance tracking, God Wars Dungeon faction detection,
Slayer task integration, item disguise detection (Greegrees, Ethereum
Bracelet, Vyre noble, Mourner gear), and minigame/raid mode.

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Apr 23, 2026

Hash for Gson inject.
@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Apr 23, 2026

This plugin requires reviews from Plugin Hub reviewers. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@riktenx
Copy link
Copy Markdown
Member

riktenx commented May 15, 2026

do not put your marker file in a subdirectory

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label May 15, 2026
Pulled out of the subdirectory for the user
@runelite-github-app runelite-github-app Bot removed waiting for author waiting for the pr author to make changes or respond to questions size-0 labels May 17, 2026
newest hash
@riktenx
Copy link
Copy Markdown
Member

riktenx commented May 17, 2026

use build=standard, not gradle

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label May 17, 2026
Hash update
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label May 17, 2026
@riktenx
Copy link
Copy Markdown
Member

riktenx commented May 17, 2026

https://github.com/runelite/runelite/wiki/Rejected-or-Rolled-Back-Features

ID based plugins: Plugins that use player provided IDs for the entirety of their functionality can cause moderation issues and outcomes that break Jagex's plugin rules. Due to this fact we will not be accepting any new ID based plugins. Plugins that use a specific set of IDs but do not allow user input will still be accepted. (e.g. plugins like Vardorvis Projectiles which only allows you to change a specific projectile to a set list of projectiles.)

(we understand that plugins like better npc highlight exist today that have ID input. items on the rejected list are not enforced retroactively and certain plugins may be grandfathered in)

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label May 17, 2026
@Bellefeu
Copy link
Copy Markdown
Contributor Author

https://github.com/runelite/runelite/wiki/Rejected-or-Rolled-Back-Features

ID based plugins: Plugins that use player provided IDs for the entirety of their functionality can cause moderation issues and outcomes that break Jagex's plugin rules. Due to this fact we will not be accepting any new ID based plugins. Plugins that use a specific set of IDs but do not allow user input will still be accepted. (e.g. plugins like Vardorvis Projectiles which only allows you to change a specific projectile to a set list of projectiles.)

(we understand that plugins like better npc highlight exist today that have ID input. items on the rejected list are not enforced retroactively and certain plugins may be grandfathered in)

Thank you for the feedback. The manual ID override fields are a minor supplementary feature. The plugin's core functionality relies entirely on wiki-sourced NPC data, hardcoded aggression rules, combat level calculations, and game state detection. Would removing the manual override config fields be sufficient to address this concern, or is the plugin rejected outright?

@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label May 17, 2026
@riktenx
Copy link
Copy Markdown
Member

riktenx commented May 17, 2026

you can't have an id-based input, everything else appears to be fine

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label May 17, 2026
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label May 18, 2026
@Bellefeu
Copy link
Copy Markdown
Contributor Author

you can't have an id-based input, everything else appears to be fine

Great, thank you. 2nd and 3rd hash pushes are a logic fix for my passive heuristics and abyssal bracelet (bug), and a few mislabeled NPC IDs. User entry NPC IDs has been removed as requested.

@riktenx riktenx closed this May 24, 2026
@riktenx riktenx reopened this May 24, 2026
@runelite-github-app runelite-github-app Bot merged commit 0beb0e6 into runelite:master May 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants