Skip to content

Bump commit to 33a8b62 (v0.3.0)#11671

Merged
runelite-github-app[bot] merged 1 commit into
runelite:masterfrom
alisendjsc-crypto:update-osrs-mining-stats-v0.3.0
Apr 28, 2026
Merged

Bump commit to 33a8b62 (v0.3.0)#11671
runelite-github-app[bot] merged 1 commit into
runelite:masterfrom
alisendjsc-crypto:update-osrs-mining-stats-v0.3.0

Conversation

@alisendjsc-crypto
Copy link
Copy Markdown
Contributor

@alisendjsc-crypto alisendjsc-crypto commented Apr 28, 2026

Bumps the pinned commit for osrs-mining-stats to 33a8b62b43f879cae17bccd268cc65c7210fbc05 for v0.3.0.

What changed

Detection contract widens by exactly one disjunct on the item-source signal: the bank container is now a valid secondary surface alongside the player inventory. The animation gate (3-second pickaxe-family activity window) and Mining-XP-delta coincidence (1200ms / ~2 game ticks) are unchanged. A bank-positive delta is counted only if no inventory-negative delta occurred within the same window — the manual-banking filter that prevents a deposit-all from being misread as a mining yield.

Why

Distributed clan testing of v0.2.0 surfaced a recurring failure surface in OSRS Leagues. With the auto-bank or auto-smelt relics active in Leagues VI "Demonic Pacts" (Hotfoot, etc.), mined items route directly to the bank — the player inventory never receives them, so v0.2.0's inventory-only detection observes no item-source signal and counts nothing. Leagues events run for around 50-60 days but recur only roughly annually — a documented limitation would persist across multiple year-long cycles. The architectural fix also generalizes cleanly to any future auto-deposit content.

Scope

Detection-contract widening only. No new config toggles, no changes to the rolling window, the AFK accounting, the per-ore breakdown, the session-persistence layer, the title-color indicator, the auto-hide logic, or the icon. The Wintertodt false-positive killer (animation gate must be pickaxe-family) is preserved.

Hub-rule compliance

Passive overlay only. The bank container is read via the existing ItemContainerChanged event subscription path used elsewhere in the hub (e.g., Bank Memory plugin). No input automation, no hidden-information exposure, no API misuse. Same posture as v0.1.x and v0.2.0.

Tests

76/76 green: 58 v0.2.0 baseline + 13 new MiningSuccessGateTest cases (Leagues happy path, manual-banking filter, baseline-on-first-bank-snapshot, multi-tick auto-deposit, held-diff merging, reset hygiene, partial deposits) + 5 new InventoryDeltaTest cases for the new hasNegativeDelta helper.

Source

https://github.com/alisendjsc-crypto/osrs-mining-stats

@runelite-github-app
Copy link
Copy Markdown

@runelite-github-app
Copy link
Copy Markdown

Internal use only: Reviewer details Maintainer details

@runelite-github-app runelite-github-app Bot merged commit 344c3ac into runelite:master Apr 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant