Bump commit to 33a8b62 (v0.3.0)#11671
Merged
runelite-github-app[bot] merged 1 commit intoApr 28, 2026
Merged
Conversation
|
Internal use only: Reviewer details Maintainer details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the pinned commit for
osrs-mining-statsto33a8b62b43f879cae17bccd268cc65c7210fbc05for v0.3.0.What changed
Detection contract widens by exactly one disjunct on the item-source signal: the bank container is now a valid secondary surface alongside the player inventory. The animation gate (3-second pickaxe-family activity window) and Mining-XP-delta coincidence (1200ms / ~2 game ticks) are unchanged. A bank-positive delta is counted only if no inventory-negative delta occurred within the same window — the manual-banking filter that prevents a deposit-all from being misread as a mining yield.
Why
Distributed clan testing of v0.2.0 surfaced a recurring failure surface in OSRS Leagues. With the auto-bank or auto-smelt relics active in Leagues VI "Demonic Pacts" (Hotfoot, etc.), mined items route directly to the bank — the player inventory never receives them, so v0.2.0's inventory-only detection observes no item-source signal and counts nothing. Leagues events run for around 50-60 days but recur only roughly annually — a documented limitation would persist across multiple year-long cycles. The architectural fix also generalizes cleanly to any future auto-deposit content.
Scope
Detection-contract widening only. No new config toggles, no changes to the rolling window, the AFK accounting, the per-ore breakdown, the session-persistence layer, the title-color indicator, the auto-hide logic, or the icon. The Wintertodt false-positive killer (animation gate must be pickaxe-family) is preserved.
Hub-rule compliance
Passive overlay only. The bank container is read via the existing
ItemContainerChangedevent subscription path used elsewhere in the hub (e.g., Bank Memory plugin). No input automation, no hidden-information exposure, no API misuse. Same posture as v0.1.x and v0.2.0.Tests
76/76 green: 58 v0.2.0 baseline + 13 new
MiningSuccessGateTestcases (Leagues happy path, manual-banking filter, baseline-on-first-bank-snapshot, multi-tick auto-deposit, held-diff merging, reset hygiene, partial deposits) + 5 newInventoryDeltaTestcases for the newhasNegativeDeltahelper.Source
https://github.com/alisendjsc-crypto/osrs-mining-stats