Skip to content

Updateing my Plugin Skilling Loot Tracker#11852

Merged
LlemonDuck merged 23 commits into
runelite:masterfrom
RyUkY-Hub:master
May 12, 2026
Merged

Updateing my Plugin Skilling Loot Tracker#11852
LlemonDuck merged 23 commits into
runelite:masterfrom
RyUkY-Hub:master

Conversation

@RyUkY-Hub
Copy link
Copy Markdown
Contributor

No description provided.

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented May 10, 2026

Plugin repository has changed

skillingloottracker: 99b12f775d0b9959bc95db3b3f148e20a71236f7..8ae9bdf7a3fb821d96528f7f95b8678298610eb8

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented May 10, 2026

This plugin requires reviews from Plugin Hub reviewers. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@RyUkY-Hub
Copy link
Copy Markdown
Contributor Author

Hey, just checking in to see if I may have missed something. I’ve reuploaded this update for the second day in a row and haven’t received a response yet. I completely understand if the review process takes some time. I just wanted to check on the status and make sure everything was submitted correctly. Appreciate your time, and I don’t mean to come across as pushy.

@RyUkY-Hub
Copy link
Copy Markdown
Contributor Author

ready for review

@RyUkY-Hub
Copy link
Copy Markdown
Contributor Author

RyUkY-Hub commented May 11, 2026

Skilling Loot Tracker v1.5.0

What it does

Automatically tracks items gained from Fishing, Mining, and Woodcutting with live GE prices and GP/hr calculation.

Feature Checklist

  • Runs client-side only. No external servers or network calls
  • No automation. Read-only tracking of game events
  • Uses official RuneLite API: ItemContainerChanged, ItemManager, ClientToolbar
  • Respects user privacy. All data stored locally in .runelite/skilling-loot-tracker/
  • Performance tested. <0.1% client tick impact with 500+ items tracked

Testing Done

  1. Tested with: Crystal rod, dragon pickaxe, infernal axe
  2. Tested methods: 3-tick fishing, barehanded mining, tick manipulation WC
  3. Verified GE price updates and session reset works
  4. No conflicts with: XP Tracker, Loot Tracker, Bank Tags

Risk Assessment

This plugin provides information already visible to the player. It does not interact with the game world, predict RNG, or automate inputs. Similar to existing Loot Tracker but scoped to gathering skills only.

Checklist

  • ./gradlew check passes locally
  • Tested on latest RuneLite release + nightly
  • Follows Plugin Hub guidelines and Jagex rules

@LlemonDuck
Copy link
Copy Markdown
Contributor

what's up with the repo change?

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label May 11, 2026
@RyUkY-Hub
Copy link
Copy Markdown
Contributor Author

my GitHub name was changed thats all

@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label May 11, 2026
@RyUkY-Hub
Copy link
Copy Markdown
Contributor Author

what's up with the repo change?

my GitHub name was changed thats all

@RyUkY-Hub
Copy link
Copy Markdown
Contributor Author

you should be able to confirm by this using old link it should re direct you

@LlemonDuck
Copy link
Copy Markdown
Contributor

there is no such net.runelite gradle plugin, nor is there any matching plugin that would give you a runelite configuration block in build.gradle.

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label May 12, 2026
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label May 12, 2026
@RyUkY-Hub
Copy link
Copy Markdown
Contributor Author

I JUST WENT BACK TO THE OLF ONE IS THAT RIGHT JUST UPDATES THE 1.5.0

@LlemonDuck
Copy link
Copy Markdown
Contributor

lombok 1.18.32 is not within our gradle verification metadata

It seems you don't really understand what you're doing with gradle. Since you're using build=standard, your build.gradle should really just be a copy of the build.gradle in the runelite/example-plugin repo

@RyUkY-Hub
Copy link
Copy Markdown
Contributor Author

now that my discord is connected to my get hub will it auto give me a role so i can see when i get updates easier

@LlemonDuck
Copy link
Copy Markdown
Contributor

now that my discord is connected to my get hub will it auto give me a role so i can see when i get updates easier

you can monitor the #github channel in the runelite discord if you want, but it won't ping you or anything. email notifications here on github are likely to be your best bet

@RyUkY-Hub
Copy link
Copy Markdown
Contributor Author

plugins {
id 'java'
}

group 'net.runelite.client.plugins.skillloottracker'
version '1.0.0'

// This section tells the computer where to find RuneLite's code
repositories {
mavenLocal()
mavenCentral()
maven {
url = 'https://runelite.net'
}
}

def runeliteVersion = '1.10.33' // Update this to the current RuneLite version if needed

dependencies {
// These are the "libraries" your plugin needs to work
compileOnly group: 'net.runelite', name: 'api', version: runeliteVersion
compileOnly group: 'net.runelite', name: 'client', version: runeliteVersion

// Lombok handles your @Getter and @Setter
compileOnly 'org.projectlombok:lombok:1.18.30'
annotationProcessor 'org.projectlombok:lombok:1.18.30'

// Google Guice handles the @Inject
compileOnly 'com.google.inject:guice:6.0.0'

// GSON handles the JSON saving/loading
compileOnly 'com.google.code.gson:gson:2.10.1'

// Testing tools for your PluginLuncher
testImplementation group: 'net.runelite', name: 'api', version: runeliteVersion
testImplementation group: 'net.runelite', name: 'client', version: runeliteVersion

}

tasks.withType(JavaCompile) {
options.encoding = 'UTF-8'
options.release = 11 // RuneLite currently uses Java 11 for plugins
}

doses this look right i am vary new to this IntelliJ im use to working on gta 5 rp scripts in just html and .ccs sorry

@LlemonDuck
Copy link
Copy Markdown
Contributor

just copy+paste the exact file i linked you. don't change anything in it except for def pluginMainClass = 'com.example.ExamplePluginTest' to match your own plugin class

@RyUkY-Hub
Copy link
Copy Markdown
Contributor Author

okay just copy AND CHANGED
def pluginMainClass = 'com.example.ExamplePluginTest'

TO def pluginMainClass = 'net.runelite.client.plugins.skillloottracker'

@RyUkY-Hub
Copy link
Copy Markdown
Contributor Author

IT SHGOULD BE com.ryuky.client.plugins.skillloottracker SHOULKDENT IT

@RyUkY-Hub
Copy link
Copy Markdown
Contributor Author

OKAY SHOULD BE ALL GOOD

@LlemonDuck LlemonDuck merged commit 4aec4db into runelite:master May 12, 2026
3 checks passed
@RyUkY-Hub
Copy link
Copy Markdown
Contributor Author

image I WAS HEY IM TRYING TO ADD A IMAGE HERE CAN I ADD THIS TO MY build.gradle OR WILL IT BRAKE IT runelite { iconPath = "icon.png" }

@LlemonDuck
Copy link
Copy Markdown
Contributor

Can you please talk like a normal person? Format your questions reasonably, not all caps, etc? We're volunteer reviewers and you will be more likely to receive help if your requests are well formed.

Place an icon.png in the root of your project directory. You do not need to modify build.gradle to have a plugin icon.

@RyUkY-Hub
Copy link
Copy Markdown
Contributor Author

this is what i found on google or is there i different way to set it this is just what i saw looking in google i don't know how this image is being handled

@LlemonDuck
Copy link
Copy Markdown
Contributor

Place an icon.png in the root of your project directory. You do not need to modify build.gradle to have a plugin icon.

@RyUkY-Hub
Copy link
Copy Markdown
Contributor Author

thanks vary sorry english is not a strong soot of mine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants