Skip to content

Global Chat: Bug Fixes#11885

Merged
LlemonDuck merged 4 commits into
runelite:masterfrom
RusseII:patch-1
May 12, 2026
Merged

Global Chat: Bug Fixes#11885
LlemonDuck merged 4 commits into
runelite:masterfrom
RusseII:patch-1

Conversation

@RusseII
Copy link
Copy Markdown
Contributor

@RusseII RusseII commented May 12, 2026

  • Fixes bugs with crashing on leagues / quest worlds
  • Reduce requests to save on costs

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented May 12, 2026

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented May 12, 2026

Feedback:

  • java.lang.System.err: system i/o, use a logger instead.
  • java.lang.Exception.printStackTrace: system i/o, use a logger instead.
  • java.lang.System.out: system i/o, use a logger instead.

A new scan will be automatically performed on the next push to the PR branch.


Internal use only: Reviewer details Maintainer details

@RusseII
Copy link
Copy Markdown
Contributor Author

RusseII commented May 12, 2026

Feedback:
java.lang.System.err: system i/o, use a logger instead.
java.lang.Exception.printStackTrace: system i/o, use a logger instead.
java.lang.System.out: system i/o, use a logger instead.

Not sure what that is about. Didn't touch any of that in my changes, let me know if I need to fix something. TYSM!

@LlemonDuck
Copy link
Copy Markdown
Contributor

Not sure what that is about. Didn't touch any of that in my changes, let me know if I need to fix something. TYSM!

they're being picked up by your ably dep. you don't need to do anything

@LlemonDuck LlemonDuck merged commit 234c18c into runelite:master May 12, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants