Skip to content

Add drop-rates-clog#11886

Merged
runelite-github-app[bot] merged 5 commits into
runelite:masterfrom
pairofcrocs:add-drop-rates-clog
May 17, 2026
Merged

Add drop-rates-clog#11886
runelite-github-app[bot] merged 5 commits into
runelite:masterfrom
pairofcrocs:add-drop-rates-clog

Conversation

@pairofcrocs
Copy link
Copy Markdown
Contributor

Adds the Clog Drop Rates plugin.

Shows drop rates in a tooltip when hovering over items in the Collection Log. Drop rate data is bundled as a JSON resource — no external service calls are made.

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented May 12, 2026

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented May 12, 2026

Internal use only: Reviewer details Maintainer details

@riktenx riktenx closed this May 17, 2026
@riktenx riktenx reopened this May 17, 2026
@riktenx
Copy link
Copy Markdown
Member

riktenx commented May 17, 2026

your plugin is able to and should use build=standard (not gradle) if you want this to be automatically reviewed

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label May 17, 2026
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label May 17, 2026
@runelite-github-app runelite-github-app Bot merged commit 2cae700 into runelite:master May 17, 2026
3 checks passed
@pairofcrocs
Copy link
Copy Markdown
Contributor Author

Going forward on updating this plugin, what would you suggest my best course of action?

The plugin pulls the json list to determine drop rates for the overlay. Obviously this changes frequently with items begin added, removed, or changed.

My first thought was to run a GH action checking the API for changes, merging those into the json, and automatically open a PR.

Will that be too much, or is there a better approach that you'd prefer?

@riktenx
Copy link
Copy Markdown
Member

riktenx commented May 17, 2026

your plugin is reviewable by the bot, which is generally rate limited, so any sort of procedural update you do like that should be fine

your automated action stuff makes sense, just when you do that make sure you keep your "scripting" code to update your jsons out of the main/ source set so the bot doesn't have to review it. you could do that in the form of like a general bash script, or if you wanted to write it in java you could just make a new source set.

i do something just like the latter in my plugin if you want an example, see https://github.com/riktenx/loot-filters/blob/main/src/script/java/com/lootfilters/UpdateDefaultFilters.java and the associated config in build.gradle (you will still be able to use build=standard)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants