tile-overlay-indicators

[Resh404]

This PR updates the improved-tile-indicators plugin entry to point to a fork with new functionality. Since the original maintainer is unresponsive, these enhancements have been developed in a separate repository.

The new features are described in: Resh404/tileindicators#1

[runelite-github-app]

New plugin tile-overlay-indicators: https://github.com/Resh404/tileindicators/tree/07c0264ca434f29a0ccf4489f7d17e4223a3e6a7

[tylerwgrass]

Please read https://github.com/runelite/runelite/wiki/Plugin-takeover-policy

I'm also not sure how you can conclude the author is unresponsive when you opened your PR 7 hours ago

[runelite-github-app]

Internal use only: Reviewer details Maintainer details

[Resh404]

Please read https://github.com/runelite/runelite/wiki/Plugin-takeover-policy

I'm also not sure how you can conclude the author is unresponsive when you opened your PR 7 hours ago

The last merge took him 6 weeks for pretty major fix. Doubt he will be very responsive. I just now read https://github.com/runelite/runelite/wiki/Plugin-takeover-policy and will wait unless I am supposed to do something else?

[Felanbird]

and will wait unless I am supposed to do something else?

[pajlada]

Please enable issues in your new repository

Please change your config key to a unique config key to match your new plugin https://github.com/Resh404/tileindicators/blob/e3a72ab165248910be6157471fadc73090e305a5/src/main/java/io/leikvolle/tileindicators/ImprovedTileIndicatorsConfig.java#L32

[Resh404]

Please enable issues in your new repository

Please change your config key to a unique config key to match your new plugin https://github.com/Resh404/tileindicators/blob/e3a72ab165248910be6157471fadc73090e305a5/src/main/java/io/leikvolle/tileindicators/ImprovedTileIndicatorsConfig.java#L32

Both comments are solved

[Resh404]

Any review for this? It is mostly reused code from existing plugin in the hub

[riktenx]

The ID-based exclusion you have added is not allowed per https://github.com/runelite/runelite/wiki/Rejected-or-Rolled-Back-Features

ID based plugins: Plugins that use player provided IDs for the entirety of their functionality can cause moderation issues and outcomes that break Jagex's plugin rules. Due to this fact we will not be accepting any new ID based plugins. Plugins that use a specific set of IDs but do not allow user input will still be accepted. (e.g. plugins like Vardorvis Projectiles which only allows you to change a specific projectile to a set list of projectiles.)

[Resh404]

The ID-based exclusion you have added is not allowed per https://github.com/runelite/runelite/wiki/Rejected-or-Rolled-Back-Features

ID based plugins: Plugins that use player provided IDs for the entirety of their functionality can cause moderation issues and outcomes that break Jagex's plugin rules. Due to this fact we will not be accepting any new ID based plugins. Plugins that use a specific set of IDs but do not allow user input will still be accepted. (e.g. plugins like Vardorvis Projectiles which only allows you to change a specific projectile to a set list of projectiles.)

If the player provides the NPC name and I use that name to look up the NPC ID and then use the exclusion, is that allowed? The earth shield object is a bit weird, because excluding it by name does not work; it has to be the NPC ID. A similar thing happens in Better NPC Highlights: if you use "Better NPC Highlights" to hide Earthen Shield by name, it does not work, but if you use the ID, it does.

[riktenx]

as long as you are not doing direct ID input it is fine. note that better npc highlight is grandfathered in general for the id thing (we reject this all the time and people always ask)

[Resh404]

The ID-based exclusion you have added is not allowed per https://github.com/runelite/runelite/wiki/Rejected-or-Rolled-Back-Features

ID based plugins: Plugins that use player provided IDs for the entirety of their functionality can cause moderation issues and outcomes that break Jagex's plugin rules. Due to this fact we will not be accepting any new ID based plugins. Plugins that use a specific set of IDs but do not allow user input will still be accepted. (e.g. plugins like Vardorvis Projectiles which only allows you to change a specific projectile to a set list of projectiles.)

Changed it to use player npc name (string) input