log-adviser: remove third-party warning (TempleOSRS call removed)#12010
Closed
SFranciscoSouza wants to merge 1 commit into
Closed
log-adviser: remove third-party warning (TempleOSRS call removed)#12010SFranciscoSouza wants to merge 1 commit into
SFranciscoSouza wants to merge 1 commit into
Conversation
The TempleOSRS collection-log fetch has been removed from the plugin. It now only calls Jagex's own secure.runescape.com Hiscores endpoint (the same one RuneLite core uses), so no IP/RSN is sent to any third-party server and the warning no longer applies. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
runelite-github-app
Bot
added
plugin change
size-s
warning change
|
Plugin warning has changed
|
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
Contributor
Author
|
Closing in favour of a fresh PR: the plugin now makes zero network requests at all (the OSRS Hiscores call has also been removed, not just TempleOSRS), so the bump points at a new commit. Superseded by an incoming PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the merged Log Adviser submission.
In review, @riktenx added a
warning=line because the plugin fetched the player's collection log from TempleOSRS (a third-party server), exposing IP + RSN.That integration has now been completely removed from the plugin (SFranciscoSouza/LogAdviser@7606822):
TempleOsrsClientis deleted along with the warm-start path and its config item. The plugin now makes a single outbound call — to Jagex's ownsecure.runescape.comHiscores endpoint, the same one RuneLite core uses — so no IP/RSN reaches any third-party server.This PR therefore:
commit=to the new760682235de42179c3167960d6ce7ca9718db5bcwarning=line🤖 Generated with Claude Code