log-adviser: fix Farmer's outfit collection log slots for Body-type-B characters#12037
Merged
runelite-github-app[bot] merged 2 commits intoMay 18, 2026
Conversation
fd214ea to
dc0089e
Compare
|
This plugin requires reviews from Plugin Hub reviewers. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the pinned commit for log-adviser to
d636c05.What this fixes
Each Tithe Farm Farmer's outfit piece is a single collection log slot but can be filled by two different items depending on the character's body type (A/B):
The plugin's slot data only carried the Body-type-A id, so a Body-type-B player's items matched nothing in either sync path (collection-log widget scrape or chat notification), and up to four slots were missed — leaving the plugin's collected total below the in-game total.
The update maps each Body-type-B id (and the shirt/jacket chat names that the slash slot name never matches) onto its canonical id, and canonicalises obtained items so the stored set only ever holds canonical ids (no double-counting). Previously-missing slots self-heal on the next collection log open; no user action or data reset required.
A focused JUnit test covers slot resolution for both body types, name resolution, canonicalisation, and the no-double-count guarantee.
./gradlew buildis green.