Skip to content

log-adviser: fix Farmer's outfit collection log slots for Body-type-B characters#12037

Merged
runelite-github-app[bot] merged 2 commits into
runelite:masterfrom
SFranciscoSouza:log-adviser-farmer-bodytype-fix
May 18, 2026
Merged

log-adviser: fix Farmer's outfit collection log slots for Body-type-B characters#12037
runelite-github-app[bot] merged 2 commits into
runelite:masterfrom
SFranciscoSouza:log-adviser-farmer-bodytype-fix

Conversation

@SFranciscoSouza
Copy link
Copy Markdown
Contributor

Bumps the pinned commit for log-adviser to d636c05.

What this fixes

Each Tithe Farm Farmer's outfit piece is a single collection log slot but can be filled by two different items depending on the character's body type (A/B):

Slot Body type A Body type B
Farmer's boro trousers 13640 13641
Farmer's shirt/jacket 13642 13643
Farmer's boots 13644 13645
Farmer's strawhat 13646 13647

The plugin's slot data only carried the Body-type-A id, so a Body-type-B player's items matched nothing in either sync path (collection-log widget scrape or chat notification), and up to four slots were missed — leaving the plugin's collected total below the in-game total.

The update maps each Body-type-B id (and the shirt/jacket chat names that the slash slot name never matches) onto its canonical id, and canonicalises obtained items so the stored set only ever holds canonical ids (no double-counting). Previously-missing slots self-heal on the next collection log open; no user action or data reset required.

A focused JUnit test covers slot resolution for both body types, name resolution, canonicalisation, and the no-double-count guarantee. ./gradlew build is green.

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented May 18, 2026

@SFranciscoSouza SFranciscoSouza force-pushed the log-adviser-farmer-bodytype-fix branch from fd214ea to dc0089e Compare May 18, 2026 19:59
@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented May 18, 2026

This plugin requires reviews from Plugin Hub reviewers. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@runelite-github-app runelite-github-app Bot merged commit cebb9fe into runelite:master May 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant