Skip to content

add color-locked#12129

Merged
runelite-github-app[bot] merged 10 commits into
runelite:masterfrom
unidarkshin:add-color-locked
May 25, 2026
Merged

add color-locked#12129
runelite-github-app[bot] merged 10 commits into
runelite:masterfrom
unidarkshin:add-color-locked

Conversation

@unidarkshin
Copy link
Copy Markdown
Contributor

Plugin: Color Locked

Group Iron color-lock enforcement plugin.

  • Blocks Eat/Drink/Equip/Wield/Wear on items restricted by the player's assigned color
  • Strips Mine/Chop when carrying a restricted pickaxe or axe
  • Marks restricted items with a red overlay in inventory, bank, and worn equipment
  • Includes a sidebar for looking up which items each color can use
  • Syncs assigned color and item rules from a hub group, or runs standalone with manual settings

Repository: https://github.com/unidarkshin/osrs-color-lock-runelite
License: BSD-2-Clause
No third-party dependencies — only RuneLite client APIs and transitive Gson.

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented May 22, 2026

unidarkshin and others added 3 commits May 22, 2026 16:47
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented May 23, 2026

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

unidarkshin and others added 2 commits May 23, 2026 13:21
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@riktenx
Copy link
Copy Markdown
Member

riktenx commented May 23, 2026

use of thread interrupt is not allowed
use of javanet httpclient is not allowed, inject and use runelite's OkHttpClient instead

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label May 23, 2026
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label May 23, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@unidarkshin
Copy link
Copy Markdown
Contributor Author

@riktenx I fixed those two issues - thank you.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@riktenx
Copy link
Copy Markdown
Member

riktenx commented May 24, 2026

use of httpurlconnection is not allowed, all networking should be through okhttp

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label May 24, 2026
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label May 24, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@unidarkshin
Copy link
Copy Markdown
Contributor Author

@riktenx Got it, I've removed all httpurlconnection references in favor of okhttp.

@riktenx
Copy link
Copy Markdown
Member

riktenx commented May 24, 2026

thread sleep and thread interrupt are not allowed eihter

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label May 24, 2026
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label May 25, 2026
@unidarkshin
Copy link
Copy Markdown
Contributor Author

@riktenx I've removed all thread interrupt and sleep in the latest commit.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Comment thread plugins/color-locked
@runelite-github-app runelite-github-app Bot merged commit d028795 into runelite:master May 25, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants