Update pvp-performance-tracker to v1.4.3#1224
Merged
Merged
Conversation
|
|
- fixed layout bug - clarified warning label & its tooltips
Matsyir
force-pushed
the
pvp-performance-tracker
branch
from
a4b11c4 to
8ee197d
Compare
Contributor
Author
|
Added another minor change to clarify that warning label & its related tooltips. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a layout bug that occurred when changing the state of the "config warning", which aims to help users acknowledge the existence of the config. Small bugfix, but it's a confusing bug that likely happens to most new users, and is only fixed by restarting the plugin. Used GridLayout in a dumb way + wasn't using constants, and the row count got messed up. Now using constants so this won't happen again. I probably shouldn't be using GridLayout in this case, but at this point it works and I'm afraid to change it. May do so in the next update where I plan to do a lot of UI changes.
