Skip to content

Update pvp-performance-tracker to v1.7.4#12558

Merged
runelite-github-app[bot] merged 1 commit into
runelite:masterfrom
Matsyir:pvp-performance-tracker
Jun 19, 2026
Merged

Update pvp-performance-tracker to v1.7.4#12558
runelite-github-app[bot] merged 1 commit into
runelite:masterfrom
Matsyir:pvp-performance-tracker

Conversation

@Matsyir

@Matsyir Matsyir commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

New opt-in feature which automatically uploads all of your fights to the PvP-Hub website, where it can be publicly viewed by anyone. This is disabled by default. When 2 of the same fight is uploaded, fight data is merged for more accurate results.

This properly includes the warning attribute on the config, which clearly states: "This feature will submit your RSN, fight logs, and IP address to a 3rd-party server not controlled or verified by Runelite developers."

More discussion, including links to the website itself + its github repo can be found here: Matsyir/pvp-performance-tracker#78

Many thanks to @LogicalSoIutions for creating this feature and hosting the website!

Edit:

  1. The initial commit had a build error due to new okHttpClient(), it's been replaced with an Inject and re-tested
  2. Then I had to add the build=standard parameter to the plugin.properties. I'm honestly not too sure if I should use standard or gradle, but I don't think I have any fancy build steps in neither build.gradle, or settings.gradle, so standard should be fine

@runelite-github-app

runelite-github-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

@Matsyir Matsyir force-pushed the pvp-performance-tracker branch 2 times, most recently from b451ad2 to 3e9d2e8 Compare June 11, 2026 20:23
@runelite-github-app

runelite-github-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@Matsyir

Matsyir commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

Is the printStackTrace critical to be changed? That is part of an old feature which is rarely used and likely to be removed soon anyways (Fight Analysis/Merge), since this new website essentially replicates the feature in a simpler way.

@Matsyir Matsyir changed the title Update pvp-performance tracker to v1.7.4 Update pvp-performance-tracker to v1.7.4 Jun 12, 2026
@Matsyir

Matsyir commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

Actually, I think it's best we hold off on merging this until:

  1. We add a configurable randomized delay for fights to be displayed publicly by default, so this cannot be used as a 'UAV' or scouting tool by any means. I think a default of random between ~6-20 minutes would be reasonable, then a few more manual options like, 15-45 mins, 30-120mins, 2hrs, 6hrs, 12hrs, 24hrs
  2. Opponent RSNs should be anonymized on the website, so only users who opted into the feature have their RSN displayed.

I don't think it would be too catastrophic to release as-is, but this update could definitely raise a lot of concerns without these changes.

@LogicalSoIutions I would be willing to start working on these changes probably Sunday, maybe Monday, but also feel free to get started if you'd like.

@Matsyir Matsyir closed this Jun 12, 2026
@Matsyir Matsyir reopened this Jun 13, 2026
@Matsyir Matsyir force-pushed the pvp-performance-tracker branch from 3e9d2e8 to d0b935e Compare June 13, 2026 18:57
@Matsyir

Matsyir commented Jun 13, 2026

Copy link
Copy Markdown
Contributor Author

The above changes described have been added, I believe there should no longer be any concerns in regards to this feature. Many thanks again to @LogicalSoIutions for getting it done quickly

The local "Fight analysis/merge" feature & all references has been removed as well, and I've ensured that the copyright headers are present on all source files - that's why the size went from M to L, lots of removals, and copyright header additions. Otherwise it was fairly small changes to make for these new changes.

*Edit: New commit from ~8hrs ago = minor label change on one of the new configs, to shorten the dropdown width and allow us to still read the config label a bit

*Edit2: Newest commits Jun18 => Added config option to anonymize your RSN even when you opt-in to the feature, LMS fixes related to recent changes

@Matsyir Matsyir force-pushed the pvp-performance-tracker branch from d0b935e to 9f87a57 Compare June 17, 2026 02:39
New opt-in feature automatically uploads all of your fights to the PvP-Hub website, where it can be publicly viewed by anyone. This is disabled by default. Even when you  opt-in, there is an option to anonymize your RSN

+ LMS fixes: properly assign ammo to dragon crossbow, properly detect zerker fights
@Matsyir Matsyir force-pushed the pvp-performance-tracker branch from 9f87a57 to ae25e95 Compare June 18, 2026 17:45
@runelite-github-app runelite-github-app Bot merged commit 5af1e8b into runelite:master Jun 19, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant