Update pvp-performance-tracker to v1.7.4#12558
Conversation
|
|
b451ad2 to
3e9d2e8
Compare
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
|
Is the printStackTrace critical to be changed? That is part of an old feature which is rarely used and likely to be removed soon anyways (Fight Analysis/Merge), since this new website essentially replicates the feature in a simpler way. |
|
Actually, I think it's best we hold off on merging this until:
I don't think it would be too catastrophic to release as-is, but this update could definitely raise a lot of concerns without these changes. @LogicalSoIutions I would be willing to start working on these changes probably Sunday, maybe Monday, but also feel free to get started if you'd like. |
3e9d2e8 to
d0b935e
Compare
|
The above changes described have been added, I believe there should no longer be any concerns in regards to this feature. Many thanks again to @LogicalSoIutions for getting it done quickly The local "Fight analysis/merge" feature & all references has been removed as well, and I've ensured that the copyright headers are present on all source files - that's why the size went from M to L, lots of removals, and copyright header additions. Otherwise it was fairly small changes to make for these new changes. *Edit: New commit from ~8hrs ago = minor label change on one of the new configs, to shorten the dropdown width and allow us to still read the config label a bit *Edit2: Newest commits Jun18 => Added config option to anonymize your RSN even when you opt-in to the feature, LMS fixes related to recent changes |
d0b935e to
9f87a57
Compare
New opt-in feature automatically uploads all of your fights to the PvP-Hub website, where it can be publicly viewed by anyone. This is disabled by default. Even when you opt-in, there is an option to anonymize your RSN + LMS fixes: properly assign ammo to dragon crossbow, properly detect zerker fights
9f87a57 to
ae25e95
Compare
5af1e8b
into
runelite:master
New opt-in feature which automatically uploads all of your fights to the PvP-Hub website, where it can be publicly viewed by anyone. This is disabled by default. When 2 of the same fight is uploaded, fight data is merged for more accurate results.
This properly includes the warning attribute on the config, which clearly states: "This feature will submit your RSN, fight logs, and IP address to a 3rd-party server not controlled or verified by Runelite developers."
More discussion, including links to the website itself + its github repo can be found here: Matsyir/pvp-performance-tracker#78
Many thanks to @LogicalSoIutions for creating this feature and hosting the website!
Edit:
new okHttpClient(), it's been replaced with an Inject and re-tested