Pvp performance tracker: fix 1tick gear offset bug#187
Merged
Conversation
Now tracks 'deserved damage' and also fixed a lot of minor issues. Significantly optimized UI code.
Used invokeLater with the main plugin's function, since the event calling this function occurs before other required data is loaded. Other small updates to support more weapons for deserved damage.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug with the deserved damage where the gear was 1 tick behind the animation, which indicates an attack and saves stats. So, if you did a proper "1 tick" switch and attacked on the same tick, it would use the previous tick's gear for calculations and cause invalid values.
Had to call the main plugin's function using invokeLater, since the event calling this function occurs before other required data is loaded. Other small updates to support more weapons for deserved damage. Thanks again to Mazhar for helping me test & confirm the cause of the bug, and to the helpers in discord who helped me figure out the right solution, in addition to helping me actually implement it properly after I did it wrong. Didn't think we'd find the cause/solution so quick, sorry for an update so soon after the previous one.