Skip to content

region-locker: Change repo#28

Merged
alexanderhenne merged 4 commits intorunelite:masterfrom
slaytostay:region-locker
Dec 22, 2019
Merged

region-locker: Change repo#28
alexanderhenne merged 4 commits intorunelite:masterfrom
slaytostay:region-locker

Conversation

@slaytostay
Copy link
Copy Markdown
Contributor

Change the region locker repo to take it out of dekvall's hands
Adds plugin icon

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app bot commented Dec 22, 2019

@Adam-
Copy link
Copy Markdown
Member

Adam- commented Dec 22, 2019

WIthout consent of the original plugin owner, we don't allow just forcibly taking over other users plugins. Maybe @dekvall is fine with this? If not, it should just be added as a second plugin (see how eg. there are two bronzeman plugins currently).

Also your plugin description appears to be advertising another client "ChunkLite"?

@dekvall
Copy link
Copy Markdown
Member

dekvall commented Dec 22, 2019

He's the original plugin author and i asked him if he wanted to maintain it, so this is ok with me.

@Adam-
Copy link
Copy Markdown
Member

Adam- commented Dec 22, 2019

Okay. Can you update the plugin description?

@slaytostay
Copy link
Copy Markdown
Contributor Author

Yeah maybe I should have clarified that, devkall did ask me to replace his repo.
ChunkLite was just RuneLite with this plugin added and some changes to the client for shading and other chunk features, I will not be maintaining the client any longer because of the external plugin. But since original users of the client know the name I thought it would be appropriate as a tag.

@Adam-
Copy link
Copy Markdown
Member

Adam- commented Dec 22, 2019

@slaytostay
Copy link
Copy Markdown
Contributor Author

Oh of course, I forgot that that was still there. On it.

@alexanderhenne alexanderhenne merged commit 96f2035 into runelite:master Dec 22, 2019
Car-Role added a commit to Car-Role/plugin-hub that referenced this pull request Mar 28, 2026
PR runelite#44: Firemaking — all log types via API constants (resolves runelite#37, runelite#34)
PR runelite#43: Hunter — maniacal monkey trap detection (new feature)
PR runelite#45: POH detection — exit portal scanning (resolves runelite#38, runelite#26)
Bug runelite#41: Amethyst dart tips — AnimationID.GEM_CUTTING_AMETHYST (6295) added to Crafting
Bug runelite#42: Fish cutting — BRUT_HUMAN_KNIFEUSE + sacred/infernal eels added to Cooking
Feature runelite#39: Salvaging split — separate toggles for salvaging hook vs sorting salvage
Feature runelite#40: Hotkey toggle — Keybind config + HotkeyListener via KeyManager
Feature runelite#23: Activation delay — new activationDelay config in Timing section; skilling must be detected continuously for that many ticks before the overlay appears (default 0 = immediate)
Feature runelite#28: Thieving — THIEVING_ANIMATION_IDS set (pickpocketing 881, stalls 832, Varlamore houses AnimationID.THIEVING_VARLAMORE_STEALING_VALUABLES) + thieving() config toggle
README: Added Firemaking, Magic, Sailing (Sorting), Thieving, fish cutting, amethyst, hotkey toggle, activation delay to features list

Add screenshot overlay hiding for level ups and collection log events
New config toggle "Hide overlay in screenshots" (default enabled) temporarily suppresses overlay for 3 ticks when level up messages or collection log interface appears, ensuring automatic screenshots are clean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants