Pvp Performance Tracker: replace config storage w/ local file#294
Merged
Conversation
Also added support for void, tome of fire and smoke battlestaff accuracy/damage buffs for the deserved damage statistic.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As recommended/requested, I've replaced config storage with local storage since the data was starting to get excessive with fight logs, and could very easily reach the limit where it would then be corrupted and reset. You can now export/import a json list of fights, so users have the ability to transfer data across different PCs if they really want to.
Also added support for void, tome of fire and smoke battlestaff accuracy/damage buffs for the deserved damage statistic, added various clarifications in comments.
I'm also unsetting the previously used storage config so that storage won't be redundantly used any longer.