Skip to content

Update VoiceScape#3968

Merged
Nightfirecat merged 54 commits into
runelite:masterfrom
derfurkan:voicescape-plugin
Mar 30, 2023
Merged

Update VoiceScape#3968
Nightfirecat merged 54 commits into
runelite:masterfrom
derfurkan:voicescape-plugin

Conversation

@derfurkan
Copy link
Copy Markdown
Contributor

@derfurkan derfurkan commented Mar 1, 2023 •
edited
Loading

  • Added icon
  • Removed main server
  • Fixed typo
  • Added Push-To-Talk
  • Added name hashing for security
  • Added default servers
  • Fixed bugs
  • Added support for proxies
  • Updated ReadMe Page

Furkan added 30 commits January 27, 2023 21:11
@derfurkan
Copy link
Copy Markdown
Contributor Author

derfurkan commented Mar 7, 2023

Ready to be reviewed

@Nightfirecat
Copy link
Copy Markdown
Member

Nightfirecat commented Mar 7, 2023 •
edited
Loading

FYI, all hub PRs should always be considered "ready to review" since we have no insight to your development process/conventions other than what is shown here. If something is submitted which turns out to not be ready for review, the PR should be closed or marked as draft instead of being left open.

@derfurkan
Copy link
Copy Markdown
Contributor Author

derfurkan commented Mar 7, 2023

FYI, all hub PRs should always be considered "ready to review" since we have no insight to your development process/conventions other than what is shown here. If something is submitted which turns out to not be ready for review, the PR should be closed or marked as draft instead of being left open.

You're right. I should mark this as draft and re-open this when i'm totally finished with it. I'm constantly adding new features that come into my mind so i add them and find some bugs while adding them. Thank you and have a great day!

@derfurkan derfurkan marked this pull request as draft March 7, 2023 19:41
@derfurkan derfurkan marked this pull request as ready for review March 11, 2023 08:11
@Nightfirecat
Copy link
Copy Markdown
Member

Nightfirecat commented Mar 30, 2023

You register a hotkey listener in plugin startup, but never unregister it. Please do so on plugin shutdown.
The rest LGTM

@derfurkan
Copy link
Copy Markdown
Contributor Author

derfurkan commented Mar 30, 2023

You register a hotkey listener in plugin startup, but never unregister it. Please do so on plugin shutdown. The rest LGTM

Fixed this issue and pushed it to the pull request.

@Nightfirecat Nightfirecat merged commit 839c916 into runelite:master Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

plugin change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@derfurkan @Nightfirecat