[region-locker] Update GPU#4059
Conversation
Not tested
|
We'd prefer you to not submit something that you haven't built and tested. |
That makes sense, sorry. Currently I don't have a development environment I can build and test on, I should probably just find a new maintainer. |
|
Is there any appetite for removing the need to copy the entire GPU plugin here? It would probably be easier to maintain if it could instead extend RuneLite's GPU plugin class and make the few modifications it wants. The GPU portion of the plugin could then be reduced to this: https://github.com/aHooder/region-locker/blob/80786c940a3deae405a6ac6cd62e16cc1f5c2ac7/src/main/java/com/gpu/RegionGpuPlugin.java It would require the following small change to RuneLite core though: aHooder/runelite@29b5fb2 This small bit of reflection code would also be unnecessary if those two things were made public in the core GPU plugin. Here's a full diff of the region locker changes, if that's more interesting. |
That would be perfect, thank you for this. Was looking for something like this when the plugin came out, had no idea this would be possible. |
|
I should add, I also ported this to LWJGL in the commit before the changes in my previous comment. |
|
@slaytostay I can help with maintaining region locker if you'd like. I currently maintain 117HD, so it's somewhat closely related. |
Tested and working