Skip to content

Create whos-gonna-poop#4131

Merged
Nightfirecat merged 9 commits into
runelite:masterfrom
ElOsoGroso:master
Apr 4, 2023
Merged

Create whos-gonna-poop#4131
Nightfirecat merged 9 commits into
runelite:masterfrom
ElOsoGroso:master

Conversation

@ElOsoGroso
Copy link
Copy Markdown
Contributor

Whos Gonna Poop is a plugin that highlights the orbs and player models of whoever is next to poop in Kephri in Tombs of Amascut.

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Mar 27, 2023

@Nightfirecat
Copy link
Copy Markdown
Member

This isn't allowed per Jagex's Third Party Client Guidelines:

Adds additional visual or audio indicators of a boss mechanic except in cases where this is a manually triggered external helper.

@ElOsoGroso
Copy link
Copy Markdown
Contributor Author

ElOsoGroso commented Mar 27, 2023

This isn't allowed per Jagex's Third Party Client Guidelines:

Adds additional visual or audio indicators of a boss mechanic except in cases where this is a manually triggered external helper.

Would it be allowed if the indicators were swapped manually with a button each time flies occurred? @Nightfirecat

@Nightfirecat
Copy link
Copy Markdown
Member

Nightfirecat commented Mar 28, 2023

Indicators of what? If it was indicators around the orbs only, that would be fine, as that would be mostly on par with something like the zulrah plugin, having a hotkey to advance the phase displayed in the sidebar, but not having any ingame overlays.

@ElOsoGroso
Copy link
Copy Markdown
Contributor Author

@Nightfirecat Okay, Ill adjust it to only show the orb highlights, and require a hotkey/button click to advance.

@ElOsoGroso
Copy link
Copy Markdown
Contributor Author

@Nightfirecat This has been updated to conform to the rules by requiring a hotkey to advance the orb positions during the fight, and removing the overlay highlights on the players.

@Nightfirecat
Copy link
Copy Markdown
Member

Do you need the jsoup implementation in build.gradle? It seems like your code doesn't use it at all

@ElOsoGroso
Copy link
Copy Markdown
Contributor Author

@Nightfirecat It was left in unintentionally from a previous branch. It's been removed! Thanks.

@Nightfirecat Nightfirecat merged commit e37a9b3 into runelite:master Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants