Skip to content

Create global-chat#4134

Merged
Nightfirecat merged 9 commits into
runelite:masterfrom
RusseII:global-chat
Apr 3, 2023
Merged

Create global-chat#4134
Nightfirecat merged 9 commits into
runelite:masterfrom
RusseII:global-chat

Conversation

@RusseII
Copy link
Copy Markdown
Contributor

@RusseII RusseII commented Mar 27, 2023

This creates a global chat that is shared across all players in a world that have installed the plugin. Useful for making sure you don't accidentally walk too far away and miss each others messages.

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Mar 27, 2023

Copy link
Copy Markdown
Member

@Nightfirecat Nightfirecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not call Thread.sleep() on the client thread. This would delay execution for the entire client.

Comment thread plugins/global-chat Outdated
RusseII and others added 3 commits April 2, 2023 19:16
Co-authored-by: Jordan <Nightfirecat@users.noreply.github.com>
@RusseII RusseII requested a review from Nightfirecat April 3, 2023 01:40
@RusseII
Copy link
Copy Markdown
Contributor Author

RusseII commented Apr 3, 2023

@Nightfirecat all issues have been fixed! Let me know if you need anything else.

@raiyni
Copy link
Copy Markdown
Member

raiyni commented Apr 3, 2023

Please rename your package and plugin class.

@RusseII
Copy link
Copy Markdown
Contributor Author

RusseII commented Apr 3, 2023

Please rename your package and plugin class.

Fixed in a7d42e4

@Nightfirecat Nightfirecat merged commit 92b4087 into runelite:master Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants