Skip to content

Create translation-plugin#4542

Merged
Nightfirecat merged 11 commits into
runelite:masterfrom
PlayerCoder1:PlayerCoder1-translation-plugin
Jul 17, 2023
Merged

Create translation-plugin#4542
Nightfirecat merged 11 commits into
runelite:masterfrom
PlayerCoder1:PlayerCoder1-translation-plugin

Conversation

@PlayerCoder1
Copy link
Copy Markdown
Contributor

Translates everything in the chatbox from NPC dialogs to Players talking on the side panel for now it's English to Spanish but I'm going to add more langages in the futur

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Jun 28, 2023

@Felanbird
Copy link
Copy Markdown
Contributor

Github branch names do not matter, only the file name that you are trying to add to this repo, you didn't need to open a new PR

@PlayerCoder1
Copy link
Copy Markdown
Contributor Author

Github branch names do not matter, only the file name that you are trying to add to this repo, you didn't need to open a new PR

Ah damn my bad :(

@PlayerCoder1
Copy link
Copy Markdown
Contributor Author

Update on the plugin, added more langages ES/IT/FR/NL you can directly change it from the Panel

@PlayerCoder1
Copy link
Copy Markdown
Contributor Author

What went wrong with the checks?

@Nightfirecat
Copy link
Copy Markdown
Member

You can see for yourself in the build logs: https://github.com/runelite/plugin-hub/actions/runs/5404888845/jobs/9826688261?pr=4542
Your plugin is using dependencies which we don't have in our verification template. We already have two other versions of json pinned there, I recommend you use one of those.

@PlayerCoder1
Copy link
Copy Markdown
Contributor Author

You can see for yourself in the build logs: https://github.com/runelite/plugin-hub/actions/runs/5404888845/jobs/9826688261?pr=4542 Your plugin is using dependencies which we don't have in our verification template. We already have two other versions of json pinned there, I recommend you use one of those.

Sorry very new to github, I think I updated what needed to be updated

@Nightfirecat
Copy link
Copy Markdown
Member

Your build is still failing because in runelite-plugin.properties you've set plugins=com.PlayerCoder1.translation-plugin, but there is no src/main/java/com/PlayerCoder1/translation-plugin class. It looks like it should be changed to plugins=com.PlayerCoder1.TranslationPlugin

@PlayerCoder1
Copy link
Copy Markdown
Contributor Author

Your build is still failing because in runelite-plugin.properties you've set plugins=com.PlayerCoder1.translation-plugin, but there is no src/main/java/com/PlayerCoder1/translation-plugin class. It looks like it should be changed to plugins=com.PlayerCoder1.TranslationPlugin

Ok sorry I didn't even see the build, the repo is now updated

Copy link
Copy Markdown
Member

@Nightfirecat Nightfirecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

Comment thread plugins/translation-plugin
Co-authored-by: Jordan <Nightfirecat@users.noreply.github.com>
@PlayerCoder1
Copy link
Copy Markdown
Contributor Author

The warning was added

@Nightfirecat Nightfirecat merged commit 296c81b into runelite:master Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants