Skip to content

Create loot-lens#6124

Closed
Zzeetaa wants to merge 3 commits into
runelite:masterfrom
Zzeetaa:master
Closed

Create loot-lens#6124
Zzeetaa wants to merge 3 commits into
runelite:masterfrom
Zzeetaa:master

Conversation

@Zzeetaa
Copy link
Copy Markdown

@Zzeetaa Zzeetaa commented Jun 3, 2024

a simple plugin which adds a sound effect from the content creator lens when opening chests in the gauntlet

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Jun 3, 2024

@Zzeetaa
Copy link
Copy Markdown
Author

Zzeetaa commented Jun 6, 2024

consent

proof of permission

@iProdigy
Copy link
Copy Markdown
Member

iProdigy commented Jul 15, 2024

LootConfig#greeting is unused and you should not use example as the config group: https://github.com/Zzeetaa/loot/blob/f050d97ef33e682abd533d25a46dfa9098eb7598/src/main/java/com/loot/LootConfig.java#L7

perhaps the clip volume should be adjustable via config

to read the wav resource, you should use getResourceAsStream because new File("src/main/resources/sound/loot.wav") will not work as explained here: https://github.com/runelite/plugin-hub?tab=readme-ov-file#plugin-resources

@LlemonDuck
Copy link
Copy Markdown
Contributor

Marking as draft for now. Please make the requested changes, then mark the plugin as ready for review.

@LlemonDuck LlemonDuck marked this pull request as draft July 29, 2024 16:56
@MESLewis
Copy link
Copy Markdown
Member

MESLewis commented Oct 2, 2024

Closed at author request.

@MESLewis MESLewis closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants