pvp-performance-tracker: Fix initial load bug, new statistic#614
Merged
Conversation
New statistic: offensive pray tracking. Added to overlay, panel, and fight log. Also added config sections
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug that happened on initial plugin load and triggered a modal for any new installations. Also removed that modal entirely since the behavior on Mac with always on top on was odd during client load. New statistic: offensive pray tracking (only for the player, not the opponent). Added to overlay (off by default), panel, and fight log. Also added config sections. Tested various times with old data from the previous version and it seems to be working no problem, even mixing it with new data and re-importing. Generally tested in LMS.