Update pvp-performance-tracker to v1.5.9#6490
Merged
Merged
Conversation
Includes hotfix for recent breaking issue, many thanks to discord user @ peenay for implementing and quickly testing the fix.
|
|
Sharpienero
pushed a commit
to Sharpienero/plugin-hub
that referenced
this pull request
Mar 24, 2025
Includes hotfix for recent breaking issue, many thanks to discord user @ peenay for implementing and quickly testing the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes hotfix for recent breaking issue, many thanks to discord user @ peenay for implementing and quickly testing the fix.
Not entirely tested by myself: Still have some unresolved gradle issues and wanted to get this hotfix out ASAP. The offset stuff was quickly tested by peenay and seemed to work, and that should be all that needed testing.
The other changes I added to this was simply changing the data folder name from
pvp-performance-trackertopvp-performance-tracker2, so that new data won't be mixed with the old, and I'll be able to migrate/update older data more viably in a future update. (Thanks to discord user @ redrumze for suggesting this, especially came in handy when I realized my gradle was borked)Going to test it for real the moment I see it merged, but as I described it should be fine.