Skip to content

Update pvp-performance tracker to v1.5.10#6929

Merged
Alexsuperfly merged 1 commit into
runelite:masterfrom
Matsyir:pvp-performance-tracker
Nov 8, 2024
Merged

Update pvp-performance tracker to v1.5.10#6929
Alexsuperfly merged 1 commit into
runelite:masterfrom
Matsyir:pvp-performance-tracker

Conversation

@Matsyir

@Matsyir Matsyir commented Nov 4, 2024

Copy link
Copy Markdown
Contributor

Thanks to @Macweese for these updates

@runelite-github-app

runelite-github-app Bot commented Nov 4, 2024

Copy link
Copy Markdown

@tylerwgrass

Copy link
Copy Markdown
Member

The build failed as one of the APIs was recently deprecated.

You'll need to make the update below here and here

- itemStats = PLUGIN.getItemManager().getItemStats(itemId, false);
+ itemStats = PLUGIN.getItemManager().getItemStats(itemId);

@tylerwgrass tylerwgrass added the waiting for author waiting for the pr author to make changes or respond to questions label Nov 4, 2024
@Matsyir Matsyir force-pushed the pvp-performance-tracker branch from dc08db6 to 6f20b21 Compare November 4, 2024 23:57
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Nov 4, 2024
@Matsyir

Matsyir commented Nov 5, 2024

Copy link
Copy Markdown
Contributor Author

Yay build works now, many thanks for the PR Tyler!

@Alexsuperfly Alexsuperfly merged commit c30ed9a into runelite:master Nov 8, 2024
Sharpienero pushed a commit to Sharpienero/plugin-hub that referenced this pull request Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants