Update pvp-performance-tracker to v1.7.0#8077
Conversation
|
|
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
|
I tried and failed to rebase this branch/PR to make it 1 commit instead of 2, idk how to do it without deleting the branch and re-making the PR. If it's a significant issue lmk and will do In this last commit, since the initial PR, only some minor changes: I mostly made some tooltip improvements/clarifications, moved the ghost barrage statistic to be the last/bottom-most one (it's rarely relevant), and deleted the 'copy as discord msg' feature, since it wasn't kept up to date, and everyone already uses screenshots anyways. |
9dce9a9 to
ad6b2b0
Compare
|
Alright I included the 1.6.3 threading crash fix in this, plus some other minor things, and also fixed the multi-commit nonsense 👍 |
|
Hold merge for now, need to fix how |
- new statistic: hits on robes - various fixes & improvements for ko chance/hp tracking - other various improvements, optimizations and fixes for calcs and tooltips
ad6b2b0 to
60a7279
Compare
|
Alright, should be ready again. No more silly calc loops in Render(). Also, some recent API changes seem to have made it so we don't even need to use that @ Schedule thing for the hitsplat/healthbar delays anymore (Matsyir/pvp-performance-tracker#57), so that's also simply been removed now. Still some small optimizations possible, but nothing major. It's already currently live with some stuff in Render() and seemingly works fine. |
Yet another new statistic! Along with various improvements and fixes.
The new statistic "hits on robes", it tracks how many times you were hit by melee/range while in robes. You don't want to get hit in robes. You can configure if this looks at only robe bottom, top, both, or either.

Also added a very basic new Frame/Window to display a summary of all the attacks used, in a more concise way than the fight log.

Mostly changes from these PRs, many thanks to the contributors! More details in regards to the various improvements/fixes can be found in the PRs.
Matsyir/pvp-performance-tracker#54
Matsyir/pvp-performance-tracker#55
Matsyir/pvp-performance-tracker#56