Skip to content

Update pvp-performance-tracker to v1.7.0#8077

Merged
LlemonDuck merged 1 commit into
runelite:masterfrom
Matsyir:pvp-performance-tracker
Jun 20, 2025
Merged

Update pvp-performance-tracker to v1.7.0#8077
LlemonDuck merged 1 commit into
runelite:masterfrom
Matsyir:pvp-performance-tracker

Conversation

@Matsyir

@Matsyir Matsyir commented May 23, 2025

Copy link
Copy Markdown
Contributor

Yet another new statistic! Along with various improvements and fixes.

The new statistic "hits on robes", it tracks how many times you were hit by melee/range while in robes. You don't want to get hit in robes. You can configure if this looks at only robe bottom, top, both, or either.
Screenshot 2025-05-23 185915

Also added a very basic new Frame/Window to display a summary of all the attacks used, in a more concise way than the fight log.
Screenshot 2025-05-23 185259

Mostly changes from these PRs, many thanks to the contributors! More details in regards to the various improvements/fixes can be found in the PRs.

Matsyir/pvp-performance-tracker#54
Matsyir/pvp-performance-tracker#55
Matsyir/pvp-performance-tracker#56

@runelite-github-app

runelite-github-app Bot commented May 23, 2025

Copy link
Copy Markdown

@runelite-github-app

runelite-github-app Bot commented May 23, 2025

Copy link
Copy Markdown

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@Matsyir

Matsyir commented May 24, 2025

Copy link
Copy Markdown
Contributor Author

I will re-open this soon, hold merge for now, another commit for minor fixes/improvements coming

I tried and failed to rebase this branch/PR to make it 1 commit instead of 2, idk how to do it without deleting the branch and re-making the PR. If it's a significant issue lmk and will do

In this last commit, since the initial PR, only some minor changes: I mostly made some tooltip improvements/clarifications, moved the ghost barrage statistic to be the last/bottom-most one (it's rarely relevant), and deleted the 'copy as discord msg' feature, since it wasn't kept up to date, and everyone already uses screenshots anyways.

@Matsyir Matsyir closed this May 24, 2025
@Matsyir Matsyir reopened this May 25, 2025
@Matsyir Matsyir force-pushed the pvp-performance-tracker branch from 9dce9a9 to ad6b2b0 Compare June 7, 2025 01:20
@Matsyir

Matsyir commented Jun 7, 2025

Copy link
Copy Markdown
Contributor Author

Alright I included the 1.6.3 threading crash fix in this, plus some other minor things, and also fixed the multi-commit nonsense 👍

@Matsyir

Matsyir commented Jun 14, 2025

Copy link
Copy Markdown
Contributor Author

Hold merge for now, need to fix how fight.calculateRobeHits(config.robeHitFilter()); is called during an ongoing fight, right now it's in the Overlay's Render() which is stupid, didn't notice that beforehand. It should be able to go just once per attack when new attacks are added. But otherwise the rest won't change much if anyone has started or wants to start reviewing

@Felanbird Felanbird added the waiting for author waiting for the pr author to make changes or respond to questions label Jun 14, 2025
- new statistic: hits on robes
- various fixes & improvements for ko chance/hp tracking
- other various improvements, optimizations and fixes for calcs and tooltips
@Matsyir Matsyir force-pushed the pvp-performance-tracker branch from ad6b2b0 to 60a7279 Compare June 17, 2025 23:33
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Jun 17, 2025
@Matsyir

Matsyir commented Jun 17, 2025

Copy link
Copy Markdown
Contributor Author

Alright, should be ready again.

No more silly calc loops in Render().

Also, some recent API changes seem to have made it so we don't even need to use that @ Schedule thing for the hitsplat/healthbar delays anymore (Matsyir/pvp-performance-tracker#57), so that's also simply been removed now.

Still some small optimizations possible, but nothing major. It's already currently live with some stuff in Render() and seemingly works fine.

@LlemonDuck LlemonDuck merged commit 94f3905 into runelite:master Jun 20, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants