Skip to content

Attack history#8488

Closed
sethks wants to merge 7 commits into
runelite:masterfrom
sethks:attack-history
Closed

Attack history#8488
sethks wants to merge 7 commits into
runelite:masterfrom
sethks:attack-history

Conversation

@sethks
Copy link
Copy Markdown
Contributor

@sethks sethks commented Jul 16, 2025

UI element that tracks the most recent attacks the player did with weapons and damage numbers. The player can have it show as much information as they want. Does not track player attacks directly as the player can track only the most recent up to the 5 most recent.

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Jul 16, 2025

@riktenx
Copy link
Copy Markdown
Member

riktenx commented Jul 16, 2025

Your plugin repository appears to be private.

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Jul 16, 2025
@sethks sethks closed this Jul 16, 2025
@riktenx
Copy link
Copy Markdown
Member

riktenx commented Jul 16, 2025

Check the CI build results - your plugin is using terminally deprecated APIs.

Also, you don't need to close and open PRs. Just update the commit hash.

@sethks sethks reopened this Jul 20, 2025
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Jul 20, 2025
@iProdigy iProdigy added the waiting for author waiting for the pr author to make changes or respond to questions label Jul 20, 2025
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Jul 20, 2025
@runelite-github-app
Copy link
Copy Markdown

Internal use only: Reviewer details Maintainer details

@riktenx
Copy link
Copy Markdown
Member

riktenx commented Jul 21, 2025

Regardless of the history limit, this functions as an attack counter which is expressly prohibited by Jagex's 3rd-party client guidelines.

Any features which aid any boss fights by doing any of the following are prohibited (this includes all Raids sub-bosses, Slayer bosses, Demi-bosses, and wave-based minigames, including the Fight Caves and Inferno):

  • Next attack prediction (timing or attack style)
  • Projectile targets, or target locations, as well as impact locations
  • Prayer switching indicators
  • Attack counters
  • Anything that automatically indicates where to stand, or not to stand. This applies to only automatic indicators, and not tiles which have been manually marked.

@riktenx riktenx closed this Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants