Update pvp-performance-tracker to v1.7.1

[Matsyir]

Copy of #9050, apparently when I force push while it's closed you can't re-open (ty again to sacca for spotting an issue with my ui migration)

Most of the functional changes: Support for god spells, special attacks for arkan blade, burning claws & dark bow. Double deaths now tracked. New statistic labels & improved tooltips. Various calculation & detection improvements. Renamed Deserved damage to Expected damage. Thanks to sacca for many PRs here

Many refactors to help with maintainability in the future, regarding UI generation. Here are some custom diff links to hopefully help review. Let me know if you have any questions, or if we'd rather split this into multiple PRs, but I think with these seperate diff links it should be okay. Either way, I understand if it takes a while to review.

[0]->[1]: Most of the functional changes, basically the old/current hash up to right before the UI reworks and deservedDmg renames: Matsyir/pvp-performance-tracker@43799b3...Matsyir:cd22da8bcda50a06cf9f5ecc10fe88a43fb8ba8c [12files, +230, -77]

[1]->[2]: Most of the UI reworks, before deservedDmg rename (excluding initial functional changes): Matsyir/pvp-performance-tracker@cd22da8...Matsyir:6041bf5f323483bf72cdb0cfdbae3855445b224b [12files, +1,462, -561] (this part is way bigger than I expected, surprised its not removing more than adding; but pretty straightforward to understand i think)

[2]->[3]: Renaming Deserved Damage -> Expected Damage, plus the few small remaining commits of fixes/tooltip adjustments (excluding the last 2 batches): Matsyir/pvp-performance-tracker@6041bf5...Matsyir:69ac80a72cb7797d0bdb802bdca0d960cd3033f6 [15files, +253, -231]

[3]->[4]: Applying requested formatting + a few other small fixes. Matsyir/pvp-performance-tracker@69ac80a...Matsyir:44827b1f30ac1a31353dad02c2df3383386735a9 [14files, +1,591, -1,434] (vast majority here is whitespace due to windows newlines->unix newlines on the reformats)

Commit hashes used:
[0]: 43799b39409d9dfd8e20c72ba3f90d4e20e501dd (this is the old/currently live hash)
[1]: cd22da8bcda50a06cf9f5ecc10fe88a43fb8ba8c (before ui reworks)
[2]: 6041bf5f323483bf72cdb0cfdbae3855445b224b (after ui reworks/before deservedDamage rename)
[3]: 69ac80a72cb7797d0bdb802bdca0d960cd3033f6 (initial 1.7.1 commit, before Nov changes)
[4] 44827b1f30ac1a31353dad02c2df3383386735a9 (this is the new hash being commit here, after Nov changes)

Here is a screenshot of the new UI label (not the biggest addition for how big of a refactor this was, but it will be easier to maintain). For the overlay, I properly took into consideration what happens when the left labels overlap the middle label, it's fine and not too instrusive due to the way it's layered, and they have low opacity. For the panel, it just doesn't really happen in practice, but it does also handle it relatively gracefully.

[runelite-github-app]

pvp-performance-tracker: 43799b39409d9dfd8e20c72ba3f90d4e20e501dd..44827b1f30ac1a31353dad02c2df3383386735a9

[runelite-github-app]

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.

---

Internal use only: Reviewer details Maintainer details

[LlemonDuck]

grab the source version from the runelite repo and make sure you include the license header https://github.com/Matsyir/pvp-performance-tracker/compare/43799b39409d9dfd8e20c72ba3f90d4e20e501dd..Matsyir:69ac80a72cb7797d0bdb802bdca0d960cd3033f6#diff-db2ce1aaec5ce2dc590f9c57646180b08693d10e716a09a6196ab4051c5132f2R1-R4

[LlemonDuck]

also i'd love it if you could reformat the panelfactory builders to be more legible, at least with intellij's built in formatting or the rl checkstyle

[Matsyir]

sorry for the delay in this, will try get to it soon but probably after next weekend

I thought I was already using rl checkstyle? Will double check all that though and format as needed.

[Matsyir]

Sorry again for the delays in this, been super busy with other projects lately.

I've imported RL's codestyle XML into IntelliJ as described on the wiki under "Code Conventions" and applied it to all views + TrackedStatistic, where a lot of these are initialized. Most of the formatting diff(s) were smaller than I would have expected to receive a comment on the style, so do let me know if there's something specific you wanna format further. I'm generally onboard with RL's code styling choices so I'm all ears.

I didn't run the reformat on every file since the changes were fairly minor most the time, but I am also willing to do that if we'd like in a future update or commit.

[LlemonDuck]

This would have been so much more legible and reviewed so much sooner if you used things like String.format instead of 15 concatenations in a row and abstract classes instead of 6 unnamed lambdas right after each other. for next time, if you're interested