pvp-performance-tracker: Added hp healed statistic for player & config warning#950
Merged
Merged
Conversation
also saving more data for upcoming feature, which I first need data for in order to properly test.
|
|
(removed unused imports and more code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added HP healed statistic, only for the local player as it's not as reliably tracked for the opponent. Added a "config warning", which displays a big red "NOT SETUP - CHECK CONFIG" label on the panel until you've ticked a checkbox in the config, as many people don't realize there are a few level/gear settings which actually affect dps calculations. Also removed the "simple overlay" as you can roughly achieve the same thing with the regular/custom overlay; it added too much code for nothing.
As always, tested in LMS w/ footage to double-check stats in slowmo.
I'm also saving more data for an upcoming feature I discussed in #development, which I first need data for in order to properly implement/test. Technically I could make fake data or use alts to test but it would be a nightmare vs just getting real data. (requires data from two clients fighting each other). Code relating to the upcoming feature has been removed for this release, although I'm saving more data that is not yet used.