-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Create rs3-voiceovers #9520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create rs3-voiceovers #9520
Conversation
RS3 Voiceovers plugin I've been working on
|
New plugin |
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
|
Stuff like this isn't allowed at all, you can't add visual or audio cues to PvM encounters. see https://secure.runescape.com/m=news/third-party-client-guidelines?oldschool=1
The wave spawn sounds, Zuk spawn sounds, and Amascut mechanic sounds all need to go at a minimum. |
|
I was hoping it would be fine given there's already a plugin that adds voicelines to Nex's mechanics and the fact you can add sounds based on game messages with certain plugins. Would delaying the audio by some number of ticks make this okay? That way it is no longer indicative of a mechanic as the mechanic is already underway. How about a random chance to trigger when a boss autoattacks? I assume boss spawn/defeat/player death don't count as mechanics. Do phase transitions? Parts of the fight where the boss already plays animations during which the player can't affect the fight? It would be helpful to outline what does and doesn't count if that's okay. |
nex has overhead text already
no
if it allows you to index on any element of the encounter whatsoever you cannot do it. so, the wave stuff, amascut mechanics, anything like zuk saying something on mob spawn, none of that is okay. IDK how much clearer I can make that for you
Not interested in towing the line with you here really. If we can't verify that your plugin doesn't break game rules we won't merge it. We also need to know the source of these sound files so we know that they are licenseable |
|
All audio files are downloaded from the RS3 wiki. Some I have slightly edited to better fit context (e.g. removing mention of Zuk's sword, or splicing two lines together). Here's the proposed complete list of criteria to play voicelines after I make changes - I want to confirm these criteria are okay before I implement. Any that you inform me are not allowed, I will omit.
Thanks in advance for bearing with me, appreciate the time you put into this. |
|
that's all fine |
Overhauled plugin
|
I've overhauled the plugin to match what I've outlined in my last post. I've also added some lines to the Jad challenges. This pastebin contains a list of all voiceline triggers in an easier to parse format. The plugin's readme file also has links to some videos showcasing it ingame. Please let me know if further changes need to be made. Thanks once again. |
RS3 Voiceovers plugin I've been working on. Adds voiceover from RS3 (and accompanying fake npcs) to Inferno, Vorkath, and Wardens.