Skip to content

Conversation

@ironicmemes
Copy link
Contributor

RS3 Voiceovers plugin I've been working on. Adds voiceover from RS3 (and accompanying fake npcs) to Inferno, Vorkath, and Wardens.

RS3 Voiceovers plugin I've been working on
@runelite-github-app
Copy link

runelite-github-app bot commented Nov 16, 2025

@runelite-github-app
Copy link

runelite-github-app bot commented Nov 16, 2025

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@riktenx
Copy link
Member

riktenx commented Dec 1, 2025

Stuff like this isn't allowed at all, you can't add visual or audio cues to PvM encounters. see https://secure.runescape.com/m=news/third-party-client-guidelines?oldschool=1

Adds additional visual or audio indicators of a boss mechanic except in cases where this is a manually triggered external helper.

The wave spawn sounds, Zuk spawn sounds, and Amascut mechanic sounds all need to go at a minimum.

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Dec 1, 2025
@ironicmemes
Copy link
Contributor Author

I was hoping it would be fine given there's already a plugin that adds voicelines to Nex's mechanics and the fact you can add sounds based on game messages with certain plugins.

Would delaying the audio by some number of ticks make this okay? That way it is no longer indicative of a mechanic as the mechanic is already underway. How about a random chance to trigger when a boss autoattacks?

I assume boss spawn/defeat/player death don't count as mechanics. Do phase transitions? Parts of the fight where the boss already plays animations during which the player can't affect the fight? It would be helpful to outline what does and doesn't count if that's okay.

@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Dec 1, 2025
@riktenx
Copy link
Member

riktenx commented Dec 7, 2025

already a plugin that adds voicelines to Nex's mechanics

nex has overhead text already

delaying the audio by some number of ticks

no

It would be helpful to outline what does and doesn't count

if it allows you to index on any element of the encounter whatsoever you cannot do it. so, the wave stuff, amascut mechanics, anything like zuk saying something on mob spawn, none of that is okay. IDK how much clearer I can make that for you

  • the vorkath start-of-encounter RP is fine
  • the amascut RP (the stuff that DOES NOT react to mechanics, i haven't looked at this in a minute but iirc you had some random interval stuff) is fine
  • voice on death is fine
  • a voice at encounter start is fine

Not interested in towing the line with you here really. If we can't verify that your plugin doesn't break game rules we won't merge it.

We also need to know the source of these sound files so we know that they are licenseable

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Dec 7, 2025
@ironicmemes
Copy link
Contributor Author

All audio files are downloaded from the RS3 wiki. Some I have slightly edited to better fit context (e.g. removing mention of Zuk's sword, or splicing two lines together).

Here's the proposed complete list of criteria to play voicelines after I make changes - I want to confirm these criteria are okay before I implement. Any that you inform me are not allowed, I will omit.

  • All three bosses will have start of encounter, end of encounter, and player death voicelines. For Zuk there will be one when you enter the Inferno and another when Zuk actually spawns, but if the start of Inferno one counts as wave stuff I will omit it.

  • All three bosses will have voicelines that occur at random intervals throughout the encounter. For Zuk this will include less frequent random voicelines while doing waves and different more frequent lines during the bossfight.

  • Certain non-random lines will occur at specific arbitrary intervals (e.g. Zuk will say "This has gone on too long" X minutes into the fight).

  • During wardens, I want Amascut to have a voiceline after you have killed P2, during the waiting time before you are taken to the P3 area, and then another line when you spawn in the P3 area. I get the feeling this one's not allowed but I have to make sure because I was really hoping it would be fine.

  • Ideally, I also want to add voicelines for making mistakes (i.e. literally ToA mistake tracker plugin but with voicelines added). I feel like this should be fine given that plugin exists, but if the audio makes it break the rules then I'll just have it be without audio for this.

  • Finally, I will also be adding voicelines for the overhead text of the GWD bosses - as the voicelines match the overhead text that already exists, this should be fine. I will have to manually record these from RS3 though as I can't find all of them on the wiki.

Thanks in advance for bearing with me, appreciate the time you put into this.

@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Dec 11, 2025
@riktenx
Copy link
Member

riktenx commented Dec 16, 2025

that's all fine

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Dec 16, 2025
Overhauled plugin
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Dec 29, 2025
@ironicmemes
Copy link
Contributor Author

I've overhauled the plugin to match what I've outlined in my last post. I've also added some lines to the Jad challenges. This pastebin contains a list of all voiceline triggers in an easier to parse format. The plugin's readme file also has links to some videos showcasing it ingame. Please let me know if further changes need to be made. Thanks once again.

@riktenx riktenx merged commit 7024aae into runelite:master Dec 30, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants