Skip to content

fix(init): improve subdir prompt with TTY check and --subdir flag#79

Merged
runkids merged 1 commit intomainfrom
fix/init-subdir-improvements
Mar 13, 2026
Merged

fix(init): improve subdir prompt with TTY check and --subdir flag#79
runkids merged 1 commit intomainfrom
fix/init-subdir-improvements

Conversation

@runkids
Copy link
Copy Markdown
Owner

@runkids runkids commented Mar 13, 2026

Follow-up to #78.

  • Add --subdir CLI flag for scriptable/CI usage
  • Add TTY guard so the prompt is skipped in non-interactive environments
  • Use consistent bufio.Reader for all input (no mixed fmt.Scanln)
  • Use ui.Info / ui.Success aligned with other init steps

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the init command by introducing a --subdir CLI flag for non-interactive subdirectory specification, improving its usability in automated workflows. It also refines the interactive prompt for subdirectory selection by adding a TTY check, standardizing input methods, and aligning UI messages for a more consistent and robust user experience.

Highlights

  • New CLI Flag: Introduced a --subdir CLI flag to allow specifying a subdirectory for skill storage in a scriptable or CI environment, bypassing interactive prompts.
  • Non-Interactive Environment Support: Added a TTY guard to skip the subdirectory prompt in non-interactive environments, ensuring the init command behaves predictably in automated scripts.
  • Input Consistency: Standardized input handling in useSourceSubdir to consistently use bufio.Reader, replacing mixed fmt.Scanln usage.
  • UI/UX Improvement: Aligned UI messages in the subdirectory prompt with ui.Info and ui.Success for a consistent user experience across init steps.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • cmd/skillshare/init.go
    • Added a subdir field to the initOptions struct to store the specified subdirectory.
    • Implemented parsing logic for the new --subdir command-line flag, including validation for missing arguments.
    • Modified the performFreshInit function to prioritize the --subdir flag value over interactive prompting for subdirectory selection.
    • Updated the useSourceSubdir function to include a TTY check, ensuring the prompt is only displayed in interactive terminals.
    • Replaced fmt.Scanln with bufio.NewReader for consistent input handling in useSourceSubdir.
    • Integrated ui.Info and ui.Success for displaying messages within the useSourceSubdir function, aligning with the application's UI standards.
Activity
  • The pull request was created by runkids.
  • No further human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a --subdir flag for non-interactive environments and improves the interactive prompt for specifying a subdirectory during initialization. The changes align with the pull request's goals by adding a TTY check to skip the prompt in CI and using a consistent method for reading user input. My review includes a few suggestions to improve error handling for user input and to clarify a success message.

Comment thread cmd/skillshare/init.go
Comment thread cmd/skillshare/init.go
Comment thread cmd/skillshare/init.go
…i helpers

Follow-up to #78. Adding:
- TTY guard so the prompt is skipped in non-interactive/CI environments
- --subdir CLI flag for scriptable usage
- Consistent use of bufio.Reader (no mixed fmt.Scanln)
- ui.Info / ui.Success for prompt output aligned with other init steps
@runkids runkids force-pushed the fix/init-subdir-improvements branch from 09b57a9 to 3033899 Compare March 13, 2026 02:36
@runkids runkids self-assigned this Mar 13, 2026
@runkids runkids merged commit 894b1b3 into main Mar 13, 2026
8 checks passed
@runkids runkids deleted the fix/init-subdir-improvements branch March 13, 2026 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant