Skip to content

fix: additional polling updates#794

Merged
jrvb-rl merged 1 commit intomainfrom
jrvb/fix-polling
May 1, 2026
Merged

fix: additional polling updates#794
jrvb-rl merged 1 commit intomainfrom
jrvb/fix-polling

Conversation

@jrvb-rl
Copy link
Copy Markdown
Contributor

@jrvb-rl jrvb-rl commented May 1, 2026

  • update sync polling to match the fixed async polling
  • fixed up name of the async_retry_server_poll_until() function
  • also avoid dup retry logic for long polling timeouts

The retry logic is particularly irksome. The HTTP wrappers in _base_client.py have their own retry logic which by default retries 40X responses. For long polls that use _post() this does the wrong thing, since it retries the exact previous request regardless of what the higher level polling loop might want. Skip retries in that case.

@jrvb-rl jrvb-rl requested review from dines-rl, james-rl and sid-rl May 1, 2026 21:04
@jrvb-rl jrvb-rl merged commit 26e409a into main May 1, 2026
7 checks passed
@jrvb-rl jrvb-rl deleted the jrvb/fix-polling branch May 1, 2026 21:18
@stainless-app stainless-app Bot mentioned this pull request May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants