Conversation
|
CodeAnt AI is reviewing your PR. Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
CodeAnt AI finished reviewing your PR. |
104e785 to
4d559b0
Compare
|
🧪 Testing |
4d559b0 to
a304a34
Compare
|
CodeAnt AI is running Incremental review Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
CodeAnt AI Incremental review completed. |
a304a34 to
fce5a0a
Compare
|
CodeAnt AI is running Incremental review Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
CodeAnt AI Incremental review completed. |
fce5a0a to
3f0b549
Compare
|
CodeAnt AI is running Incremental review Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
CodeAnt AI Incremental review completed. |
9958485 to
ec3bff9
Compare
|
CodeAnt AI is running Incremental review Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
| export interface AgentCreateParameters { | ||
| /** | ||
| * The name of the Agent. | ||
| */ | ||
| name: string; | ||
|
|
||
| /** | ||
| * The source configuration for the Agent. | ||
| */ | ||
| source?: Shared.AgentSource | null; | ||
| } |
There was a problem hiding this comment.
Suggestion: Replace the duplicated AgentCreateParameters interface with a type alias to the existing AgentCreateParams to avoid redundant/contradictory type definitions. [maintainability]
Severity Level: Minor
| export interface AgentCreateParameters { | |
| /** | |
| * The name of the Agent. | |
| */ | |
| name: string; | |
| /** | |
| * The source configuration for the Agent. | |
| */ | |
| source?: Shared.AgentSource | null; | |
| } | |
| export type AgentCreateParameters = AgentCreateParams; |
Why it matters? ⭐
The file currently defines two identical shapes: AgentCreateParameters (interface) and AgentCreateParams (interface). I confirmed both exist in src/resources/agents.ts. Making AgentCreateParameters a type alias to AgentCreateParams removes redundant duplicate definitions and prevents them from drifting apart in the future. The alias preserves the public type name and is fully compatible with the existing namespace re-exports in this file, so this is a safe, maintainability-focused change.
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** src/resources/agents.ts
**Line:** 49:59
**Comment:**
*Maintainability: Replace the duplicated `AgentCreateParameters` interface with a type alias to the existing `AgentCreateParams` to avoid redundant/contradictory type definitions.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.| /** | ||
| * Source type: npm, pip, object, or git | ||
| */ | ||
| type: string; |
There was a problem hiding this comment.
Suggestion: Narrow the type field to the documented literal options instead of a general string [enhancement]
Severity Level: Minor
| type: string; | |
| type: 'npm' | 'pip' | 'object' | 'git'; |
Why it matters? ⭐
The AgentSource interface in the file explicitly documents the allowed values ("Source type: npm, pip, object, or git") and provides per-type sub-objects (git, npm, object, pip). Narrowing type to the union 'npm' | 'pip' | 'object' | 'git' is a sensible type-safety improvement that matches the spec comments and the existing shape. It will make the API contracts clearer and enable better compile-time checks. I verified the current file contains the type: string; declaration and the related namespaced interfaces (AgentSource.Git, Npm, Object, Pip), so the suggested literal union aligns with the rest of the code.
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** src/resources/shared.ts
**Line:** 42:42
**Comment:**
*Enhancement: Narrow the `type` field to the documented literal options instead of a general string
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.|
CodeAnt AI Incremental review completed. |
ec3bff9 to
f720222
Compare
|
CodeAnt AI is running Incremental review Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
CodeAnt AI Incremental review completed. |
f720222 to
87a091e
Compare
|
CodeAnt AI is running Incremental review Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
CodeAnt AI Incremental review completed. |
87a091e to
5895b30
Compare
|
CodeAnt AI is running Incremental review Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
CodeAnt AI Incremental review completed. |
5895b30 to
a9f607c
Compare
… fix(storage-object): added ObjectState enum, fixed createObject() to appropriately type content_type and state as the respective enums
…ch they are automatically deleted.\nfeat(blueprints): Added the ability to attach objects as build contexts that can be referenced in your Dockerfile.
a9f607c to
6024cdb
Compare
6024cdb to
8c05f5a
Compare
|
🤖 Release is at https://github.com/runloopai/api-client-ts/releases/tag/v0.68.0 🌻 |
Automated Release PR
0.68.0 (2025-11-19)
Full Changelog: v0.67.1...v0.68.0
Features
Bug Fixes
This pull request is managed by Stainless's GitHub App.
The semver version number is based on included commit messages. Alternatively, you can manually set the version number in the title of this pull request.
For a better experience, it is recommended to use either rebase-merge or squash-merge when merging this pull request.
🔗 Stainless website
📚 Read the docs
🙋 Reach out for help or questions