fix(sdk): Fix exports of the SDK not getting clobbered#662
Conversation
|
CodeAnt AI is reviewing your PR. Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
| /^\s*exports\.default\s*=\s*([^;]+);/m, | ||
| 'module.exports = exports;\nexports.default = $1;', |
There was a problem hiding this comment.
Suggestion: The regex ([^;]+) stops at the first semicolon, so if the default export expression contains additional semicolons (e.g. a function body) the replacement truncates the expression and corrupts sdk.js; replace just the exports.default = prefix and insert module.exports = exports before it so the rest of the original expression (and its semicolons) remain untouched. [logic error]
Severity Level: Minor
| /^\s*exports\.default\s*=\s*([^;]+);/m, | |
| 'module.exports = exports;\nexports.default = $1;', | |
| /^(\s*)exports\.default\s*=\s*/m, | |
| '$1module.exports = exports;\n$1exports.default = ', |
Why it matters? ⭐
The current regex captures only until the next semicolon, so if exports.default is set to a function or object literal that contains other semicolons (common in the bundled sdk.js), the replacement slices the expression mid-stream and corrupts the file. The suggested change simply prefixes the existing assignment with module.exports = exports; while leaving the rest untouched, which avoids breaking any valid exports.default expression.
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** scripts/utils/fix-index-exports.cjs
**Line:** 13:14
**Comment:**
*Logic Error: The regex `([^;]+)` stops at the first semicolon, so if the default export expression contains additional semicolons (e.g. a function body) the replacement truncates the expression and corrupts `sdk.js`; replace just the `exports.default =` prefix and insert `module.exports = exports` before it so the rest of the original expression (and its semicolons) remain untouched.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.|
CodeAnt AI finished reviewing your PR. |
CodeAnt-AI Description
Guard SDK exports and smoke-test built package
What Changed
module.exportskeeps pointing to the exports object instead of replacing it, preventing namespace members from being dropped in the bundled SDK.Impact
✅ Prevents built SDK exports from being clobbered✅ CI runs built-package import smoke test✅ Ensures packaged SDK exposes namespaces and helper classes💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.